new(ci): push docker images to ghcr. #70
Conversation
|
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
|
/remove-lifecycle stale |
FedeDP
force-pushed
the
new/push_images_ghcr
branch
from
6edee38 to
3833586
Compare
|
We now have |
FedeDP
changed the title
|
Build is failing because :
I think we need more disk space from actuated.dev nodes. |
FedeDP
force-pushed
the
new/push_images_ghcr
branch
from
c017c98 to
132f5d7
Compare
FedeDP
force-pushed
the
new/push_images_ghcr
branch
from
132f5d7 to
93e2c52
Compare
images/Makefile
Outdated
| echo "Pushing image: $$image"; \ | ||
| docker push $$image; \ | ||
| fi; \ | ||
| docker image rm -f $(docker images -a | grep -v "initrd-builder:0.0.1" | awk 'NR>1 {print $3}'); \ |
There was a problem hiding this comment.
Clear up all images except for initrd-builder:0.0.1 that is not pushed anywhere and is only used locally as a base for other images.
FedeDP
force-pushed
the
new/push_images_ghcr
branch
from
93e2c52 to
56cff14
Compare
|
/hold |
Signed-off-by: Federico Di Pierro <[email protected]>
…modernbpf-builder now. Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
new/push_images_ghcr
branch
from
acf756f to
16fe946
Compare
images/Makefile
Outdated
| echo "Pushing image: $$image"; \ | ||
| docker push $$image; \ | ||
| fi; \ | ||
| docker image rm -f $$image; \ |
There was a problem hiding this comment.
Since images are big, we don't want to fill up the runner node disk space; therefore after each build and eventual push, clean up images.
| @@ -25,8 +25,6 @@ RUN dnf groupinstall -y 'Development Tools' && \ | |||
| xargs -I@ curl -Lo headers.rpm ${URL}@ && \ | |||
| grep -E 'kernel-devel-'${VERSION}'.*.rpm' primary.xml | grep href | cut -d\" -f2 | \ | |||
| xargs -I@ curl -Lo sources.rpm ${URL}@ && \ | |||
| grep -E 'bpftool-'${VERSION}'.*.rpm' primary.xml | grep href | cut -d\" -f2 | \ | |||
There was a problem hiding this comment.
bpftool is not needed since scap-open with modern-bpf built in gets built in a specific step with a specific rootfs.
|
There are multiple issues still since lots of distros killed headers packages that we were using (ie: they are not present anymore in their repos). |
FedeDP
force-pushed
the
new/push_images_ghcr
branch
from
cacf3f8 to
f51cdc4
Compare
Signed-off-by: Federico Di Pierro <[email protected]>
Moreover, added archlinux 6.7. Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
|
Still failing: amd64: |
…ht override kernel Makefile variable. Signed-off-by: Federico Di Pierro <[email protected]>
Also, moved ubuntu-6.3 to 6.5 and added archlinux x86_64 6.7 entry. Finally, renamed `version` in `tag`. Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
new/push_images_ghcr
branch
from
214ae89 to
777a6d1
Compare
…pported. Since virtio_mmio is not supported on this kernel. Signed-off-by: Federico Di Pierro <[email protected]>
|
Arm64 should be all ok; we are having issues with the actuated arm64 node and docker: |
FedeDP
force-pushed
the
new/push_images_ghcr
branch
3 times, most recently
from
c666823 to
612325b
Compare
… variables. Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
new/push_images_ghcr
branch
from
612325b to
56a25dd
Compare
|
/unhold |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WIP until we've got a nwe self-hosted runner associated with the
kernel-testingrepository (right now, the self-hosted is only available forlibsrepo).