-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send enter events also with scap files not only in live captures #2202
fix: send enter events also with scap files not only in live captures #2202
Conversation
4e8db3d
to
ed1b530
Compare
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2202 +/- ##
==========================================
+ Coverage 75.19% 75.38% +0.19%
==========================================
Files 261 264 +3
Lines 33880 34014 +134
Branches 5803 5805 +2
==========================================
+ Hits 25476 25642 +166
+ Misses 8404 8372 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
ed1b530
to
68f6a46
Compare
Rebased on master to fix the CI |
since write has the EF_USES_FLAG, we call `set_fd_info` in `sinsp_parser::reset` Signed-off-by: Andrea Terzolo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 5ee187ca2798f9234589300fc648d4b90f19b2f8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libscap-engine-savefile
/area libscap
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR provides 2 main fixes:
connect
or theclose
case.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: