Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(driver): update syscalls tables and driver report. #2219

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 2, 2025

This PR updates the list of supported syscalls from the latest kernel. Do not edit this PR.
/area driver

NONE

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@poiana
Copy link
Contributor

poiana commented Jan 2, 2025

@github-actions[bot]: The label(s) area/driver cannot be applied, because the repository doesn't have them.

In response to this:

This PR updates the list of supported syscalls from the latest kernel. Do not edit this PR.
/area driver

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@FedeDP
Copy link
Contributor

FedeDP commented Jan 2, 2025

Closing and reopening to trigger CI.
/close

@FedeDP
Copy link
Contributor

FedeDP commented Jan 2, 2025

/reopen

@poiana
Copy link
Contributor

poiana commented Jan 2, 2025

@FedeDP: Closed this PR.

In response to this:

Closing and reopening to trigger CI.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana poiana closed this Jan 2, 2025
@poiana
Copy link
Contributor

poiana commented Jan 2, 2025

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana poiana reopened this Jan 2, 2025
Copy link
Author

github-actions bot commented Jan 2, 2025

Please double check driver/API_VERSION file. See versioning.

/hold

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (16ece2c) to head (49c65ef).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2219   +/-   ##
=======================================
  Coverage   75.44%   75.44%           
=======================================
  Files         265      265           
  Lines       34057    34057           
  Branches     5801     5801           
=======================================
  Hits        25695    25695           
  Misses       8362     8362           
Flag Coverage Δ
libsinsp 75.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FedeDP
Copy link
Contributor

FedeDP commented Jan 2, 2025

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Jan 2, 2025
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 2, 2025

LGTM label has been added.

Git tree hash: a7cfba44c76a3be2cdc9987336669f2f8359f3dc

@poiana poiana added the approved label Jan 2, 2025
@FedeDP
Copy link
Contributor

FedeDP commented Jan 2, 2025

/unhold

Copy link
Author

github-actions bot commented Jan 2, 2025

Perf diff from master - unit tests

     5.11%     +0.53%  [.] next_event_from_file
     2.89%     -0.51%  [.] sinsp_parser::process_event
     1.55%     +0.50%  [.] next
     9.98%     +0.48%  [.] sinsp_parser::reset
     3.79%     -0.47%  [.] sinsp_thread_manager::find_thread
     3.28%     +0.41%  [.] sinsp_evt::load_params
     2.74%     -0.40%  [.] sinsp_thread_manager::get_thread_ref
     1.52%     +0.32%  [.] sinsp_evt_filter::sinsp_evt_filter
     8.52%     -0.29%  [.] sinsp_evt::get_type
     0.87%     -0.29%  [.] libsinsp::events::is_unknown_event

Heap diff from master - unit tests

peak heap memory consumption: -8B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -4B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0230         +0.0229           148           152           148           152
BM_sinsp_split_median                                          +0.0162         +0.0161           149           152           149           152
BM_sinsp_split_stddev                                          +0.6226         +0.6232             1             2             1             2
BM_sinsp_split_cv                                              +0.5861         +0.5867             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0971         +0.0971            56            62            56            62
BM_sinsp_concatenate_paths_relative_path_median                +0.0968         +0.0968            56            62            56            62
BM_sinsp_concatenate_paths_relative_path_stddev                +0.1264         +0.1272             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.0267         +0.0275             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0012         +0.0013            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0016         +0.0016            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.1039         -0.1039             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.1050         -0.1050             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0661         +0.0661            56            60            56            60
BM_sinsp_concatenate_paths_absolute_path_median                +0.0408         +0.0408            56            58            56            58
BM_sinsp_concatenate_paths_absolute_path_stddev                +9.3500         +9.3407             0             3             0             3
BM_sinsp_concatenate_paths_absolute_path_cv                    +8.7080         +8.6992             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0096         +0.0096           383           387           383           387
BM_sinsp_split_container_image_median                          +0.0110         +0.0110           384           388           384           388
BM_sinsp_split_container_image_stddev                          -0.3756         -0.3746             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.3816         -0.3806             0             0             0             0

Copy link
Author

github-actions bot commented Jan 2, 2025

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, github-actions[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97
Copy link
Member

It seems like we broke the modern on 5.8 without noticing it :/ Of course not in this PR

fedora-5.8 🟢 🟢 🟢 🟢 🟢

@poiana poiana merged commit d1881b4 into master Jan 2, 2025
60 of 62 checks passed
@poiana poiana deleted the update/syscalls branch January 2, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants