Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test/libsinsp_e2e): fixed tcp related libsinsp_e2e tests. #2234

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 15, 2025

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area tests

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Took my time and finally fixed libsinsp_e2e tcp related tests to avoid deadlocks.
This finally turns ARM CI green 🚀

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 15, 2025

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Jan 15, 2025
Copy link

Perf diff from master - unit tests

    11.28%     -1.27%  [.] sinsp::next
     1.67%     +0.88%  [.] sinsp_evt_filter::sinsp_evt_filter
     1.53%     +0.59%  [.] next
     8.22%     +0.48%  [.] sinsp_evt::get_type
    10.22%     +0.44%  [.] sinsp_parser::reset
     1.09%     -0.32%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     1.19%     -0.31%  [.] sinsp_parser::event_cleanup
     1.53%     -0.31%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     0.85%     +0.30%  [.] sinsp_evt::get_syscall_return_value
     3.93%     -0.29%  [.] sinsp_thread_manager::find_thread

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0338         +0.0338           146           151           146           151
BM_sinsp_split_median                                          +0.0340         +0.0340           146           151           146           151
BM_sinsp_split_stddev                                          +1.7115         +1.7077             1             2             1             2
BM_sinsp_split_cv                                              +1.6228         +1.6192             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0734         -0.0734            61            57            61            57
BM_sinsp_concatenate_paths_relative_path_median                -0.0710         -0.0709            61            57            61            57
BM_sinsp_concatenate_paths_relative_path_stddev                -0.7727         -0.7723             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.7547         -0.7542             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0118         -0.0118            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0131         -0.0131            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.2860         +0.2871             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.3013         +0.3025             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1467         -0.1467            64            55            64            55
BM_sinsp_concatenate_paths_absolute_path_median                -0.1536         -0.1536            64            54            64            54
BM_sinsp_concatenate_paths_absolute_path_stddev                +2.7122         +2.7128             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +3.3507         +3.3513             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0067         -0.0067           390           387           390           387
BM_sinsp_split_container_image_median                          -0.0066         -0.0066           389           387           389           387
BM_sinsp_split_container_image_stddev                          +0.0834         +0.0828             3             3             3             3
BM_sinsp_split_container_image_cv                              +0.0907         +0.0902             0             0             0             0

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.09%. Comparing base (8362ae9) to head (dbecc2c).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2234   +/-   ##
=======================================
  Coverage   75.09%   75.09%           
=======================================
  Files         276      276           
  Lines       34391    34391           
  Branches     5927     5927           
=======================================
  Hits        25826    25826           
  Misses       8565     8565           
Flag Coverage Δ
libsinsp 75.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 5891ebd into master Jan 15, 2025
57 checks passed
@poiana poiana deleted the fix/e2e_tcp_tests branch January 15, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants