Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add refresh_interval parameter #383

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Issif
Copy link
Member

@Issif Issif commented Dec 13, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

This PR introduces a new parameter refresh_interval to avoid Too many requests from the Okta API. It also introduces a deduplication of the keys to count the MFA attempts.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Thomas Labarussias <[email protected]>
Copy link

Rules files suggestions

okta_rules.yaml

Comparing d3c1bf68334f13815641bd7c66f20c930457889c with latest tag okta-0.8.1

No changes detected

@leogr
Copy link
Member

leogr commented Dec 13, 2023

/assign

@fdriouch
Copy link
Contributor

Hi everyone, I deeply appreciate your valuable contributions to this project. Would it be possible to prioritize reviewing and approving this PR? This would be immensely helpful as the issue this PR fixes is causing several daily false positives in our alerting system.

Thank you so much for your dedication.

@fdriouch
Copy link
Contributor

fdriouch commented Jan 4, 2024

Hi @jasondellaluce, @leogr, do you have any ETA in mind for reviewing this PR?
Thanks!

@poiana poiana added the lgtm label Jan 9, 2024
@poiana
Copy link
Contributor

poiana commented Jan 9, 2024

LGTM label has been added.

Git tree hash: d96a303721bf43a892a3c837515b2dc13a4c5533

@poiana
Copy link
Contributor

poiana commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Jan 9, 2024
@poiana poiana merged commit d41172a into falcosecurity:master Jan 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants