-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add driver for new hwe ubuntu generic kernel #1737
Conversation
Hi @gbittenbender. Thanks for your PR. I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gbittenbender The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi! Thanks for opening this PR! Your commit is missing DCO. Also, that's weird: we only crawl https://falcosecurity.github.io/kernel-crawler/?arch=x86_64&target=ubuntu&search=5.15.0-124-generic, but cannot find the |
Signed-off-by: gbittenbender <[email protected]>
Added the DCO. |
/ok-to-test |
Mmmh from your screenshot, i'd expect the added kernel to be:
|
Oh good catch! We found this while working on updating a new image, so I must have added the info just from the past version. I'll update since I expect we'll need both. |
Signed-off-by: gbittenbender <[email protected]>
Thanks! Also, can you share your |
@@ -0,0 +1,7 @@ | |||
kernelversion: 134~20.01.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this 134~20.04.1
?
I found this one: https://ubuntu.pkgs.org/20.04/ubuntu-updates-main-amd64/linux-image-5.15.0-130-generic_5.15.0-130.140~20.04.1_amd64.deb.html
Oh i opened falcosecurity/kernel-crawler#209; with this fix, i was able to discover the kernel :)
|
If that's ok for you, i'd let the other PR get merged and tomorrow morning our automated workflow will crawl the new kernels and then build drivers against them and publish them. |
/hold |
Yup, that works for me. Thanks! |
Hey, I Just merged #1739 with the latest crawled kernels. Thanks again for reporting the missing driver! |
@FedeDP: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Oh i forgot that we don't support
After all, if you are on 5.15, you can use the modern ebpf driver that does not require any external driver download since it is embedded in the Falco binary itself (indeed, latest Falco should already default at it). |
Was receiving 404 errors from attempting to use a ubuntu-generic HWE kernel. Similar kernel drivers appear to have been built for previous versions, so opening this pull request to create one for my desired kernel