Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver for new hwe ubuntu generic kernel #1737

Closed
wants to merge 2 commits into from

Conversation

gbittenbender
Copy link
Contributor

@gbittenbender gbittenbender commented Jan 9, 2025

Was receiving 404 errors from attempting to use a ubuntu-generic HWE kernel. Similar kernel drivers appear to have been built for previous versions, so opening this pull request to create one for my desired kernel

@poiana
Copy link
Contributor

poiana commented Jan 9, 2025

Hi @gbittenbender. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana poiana added the size/XS label Jan 9, 2025
@gbittenbender gbittenbender changed the title Add kernel for new hwe ubuntu generic kernel Add driver for new hwe ubuntu generic kernel Jan 9, 2025
@poiana
Copy link
Contributor

poiana commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gbittenbender
Once this PR has been reviewed and has the lgtm label, please assign maxgio92 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from LucaGuerra and zuc January 9, 2025 22:05
@FedeDP
Copy link
Contributor

FedeDP commented Jan 10, 2025

Hi! Thanks for opening this PR! Your commit is missing DCO.

Also, that's weird: we only crawl https://falcosecurity.github.io/kernel-crawler/?arch=x86_64&target=ubuntu&search=5.15.0-124-generic, but cannot find the 134~20.01.1 one. Can you share the ubuntu release?

Signed-off-by: gbittenbender <[email protected]>
@gbittenbender
Copy link
Contributor Author

Hi! Thanks for opening this PR! Your commit is missing DCO.

Also, that's weird: we only crawl https://falcosecurity.github.io/kernel-crawler/?arch=x86_64&target=ubuntu&search=5.15.0-124-generic, but cannot find the 134~20.01.1 one. Can you share the ubuntu release?

Added the DCO.

And yeah, it should be a pretty standard Ubuntu desktop.
image

@FedeDP
Copy link
Contributor

FedeDP commented Jan 10, 2025

/ok-to-test

@FedeDP
Copy link
Contributor

FedeDP commented Jan 10, 2025

Mmmh from your screenshot, i'd expect the added kernel to be:

5.15.0-130-generic
140~20.04.1

@gbittenbender
Copy link
Contributor Author

Mmmh from your screenshot, i'd expect the added kernel to be:

5.15.0-130-generic
140~20.04.1

Oh good catch! We found this while working on updating a new image, so I must have added the info just from the past version. I'll update since I expect we'll need both.

Signed-off-by: gbittenbender <[email protected]>
@poiana poiana added size/S and removed size/XS labels Jan 10, 2025
@FedeDP
Copy link
Contributor

FedeDP commented Jan 10, 2025

Thanks! Also, can you share your /etc/apt/sources.list file? I would love to understand where is this kernel coming from to fix the ubuntu crawler at https://github.com/falcosecurity/kernel-crawler/blob/main/kernel_crawler/ubuntu.py#L23

@@ -0,0 +1,7 @@
kernelversion: 134~20.01.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedeDP
Copy link
Contributor

FedeDP commented Jan 10, 2025

Oh i opened falcosecurity/kernel-crawler#209; with this fix, i was able to discover the kernel :)
Snippet from the crawled json:

{
      "kernelversion": "140~20.04.1",
      "kernelrelease": "5.15.0-130-hwe",
      "target": "ubuntu-hwe",
      "headers": [
        "http://archive.ubuntu.com/ubuntu/pool/main/l/linux-hwe-5.15/linux-headers-5.15.0-130-generic_5.15.0-130.140~20.04.1_amd64.deb",
        "http://archive.ubuntu.com/ubuntu/pool/main/l/linux-hwe-5.15/linux-hwe-5.15-headers-5.15.0-130_5.15.0-130.140~20.04.1_all.deb"
      ]
    },

@FedeDP
Copy link
Contributor

FedeDP commented Jan 10, 2025

If that's ok for you, i'd let the other PR get merged and tomorrow morning our automated workflow will crawl the new kernels and then build drivers against them and publish them.

@FedeDP
Copy link
Contributor

FedeDP commented Jan 10, 2025

/hold

@gbittenbender
Copy link
Contributor Author

If that's ok for you, i'd let the other PR get merged and tomorrow morning our automated workflow will crawl the new kernels and then build drivers against them and publish them.

Yup, that works for me. Thanks!

@FedeDP
Copy link
Contributor

FedeDP commented Jan 11, 2025

Hey, I Just merged #1739 with the latest crawled kernels.
The drivers should be up in a couple of hours (time to build and publish them!)

Thanks again for reporting the missing driver!
/close

@poiana poiana closed this Jan 11, 2025
@poiana
Copy link
Contributor

poiana commented Jan 11, 2025

@FedeDP: Closed this PR.

In response to this:

Hey, I Just merged #1739 with the latest crawled kernels.
The drivers should be up in a couple of hours (time to build and publish them!)

Thanks again for reporting the missing driver!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@FedeDP
Copy link
Contributor

FedeDP commented Jan 13, 2025

Oh i forgot that we don't support ubuntu-hwe prebuilt drivers :/
We only support:

  • ubuntu-aws
  • ubuntu-gke
  • ubuntu-azure
  • ubuntu-generic
  • ubuntu-gcp

After all, if you are on 5.15, you can use the modern ebpf driver that does not require any external driver download since it is embedded in the Falco binary itself (indeed, latest Falco should already default at it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants