Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): set tmdb query's default language based on locale setting #667

Closed
wants to merge 1 commit into from

Conversation

fallenbagel
Copy link
Owner

Description

From PR#627. Re-opening a PR with a cherrypick because not sure why cypress tests were failing, so to test.

The tmdb api's default language is en, there's locale issue in notification payload. Since the locale is set from settings, just get the value there.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • Fixes ###

@fallenbagel fallenbagel deleted the feat-translated-notifications branch February 23, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant