refactor: Make getDisplayname and calcAvatar of room async #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krille-chan
force-pushed
the
krille/lazy-load-users-for-avatar-displayname
branch
2 times, most recently
from
fef3a82 to
34f0c22
Compare
krille-chan
force-pushed
the
krille/lazy-load-users-for-avatar-displayname
branch
from
34f0c22 to
0afb7d7
Compare
nico-famedly
approved these changes
Dec 13, 2023
This makes it possible to await loading the hero users to correctly calculate displayname and avatar.
krille-chan
force-pushed
the
krille/lazy-load-users-for-avatar-displayname
branch
from
0afb7d7 to
9dc2f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to
load users lazy
for rooms to calculate the
name and the avatar. The
changes explain the new
behavior in detail in the
dart docs. The old
avatar getter now only
returns the avatar from the
room state m.room.avatar.