Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workaround for too big sqflite tables #1652

Closed
wants to merge 1 commit into from

Conversation

krille-chan
Copy link
Contributor

@krille-chan krille-chan commented Dec 18, 2023

Closes #1642

@krille-chan krille-chan force-pushed the krille/workaround-for-too-big-rows-sqflite branch 2 times, most recently from e3c4902 to 1e6e049 Compare December 19, 2023 06:53
@krille-chan krille-chan marked this pull request as ready for review December 20, 2023 07:26
@krille-chan krille-chan force-pushed the krille/workaround-for-too-big-rows-sqflite branch from 1e6e049 to be4048c Compare December 20, 2023 07:33
Copy link
Member

@td-famedly td-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very specific to read receipts.

2 more general solution IMHO would be:

@krille-chan
Copy link
Contributor Author

This looks very specific to read receipts.

2 more general solution IMHO would be:

This can be done as well and then the limit can just be disabled on the client side. However this is only a workaround as there is currently no better solution for #1642

@nico-famedly
Copy link
Member

I don't think just not storing receipts is a good solution. We could split them up instead of storing them as one large json, which would be better anyway, so that in the future we don't need to load the whole json when we just need a few receipts (like our own). Alternatively one of the approaches to increase the window size on android, since that seems to be the only platform with that problem.

@krille-chan
Copy link
Contributor Author

I don't think just not storing receipts is a good solution. We could split them up instead of storing them as one large json, which would be better anyway, so that in the future we don't need to load the whole json when we just need a few receipts (like our own). Alternatively one of the approaches to increase the window size on android, since that seems to be the only platform with that problem.

Well I never said this is a good solution or any solution at all. It is a workaround as any other solution would need such a huge change in all databases that it would make much more sense to do this once we have reduced the amount of databases in the sdk. But we cannot reduce the amount of databases as long as the new database is blocked by this edge case. So what solution would you suggest which does not need another weeks of development?

@krille-chan
Copy link
Contributor Author

Closed because I found a better solution

@Malesenka
Copy link

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some accounts cant load from new MatrixSdkDatabase
4 participants