-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Workaround for too big sqflite tables #1652
Conversation
e3c4902
to
1e6e049
Compare
1e6e049
to
be4048c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very specific to read receipts.
2 more general solution IMHO would be:
-
Handle this on the client side https://stackoverflow.com/questions/51959944/sqliteblobtoobigexception-row-too-big-to-fit-into-cursorwindow-requiredpos-0-t
-
or try to create a custom sqflite db as mentioned here: Window is full tekartik/sqflite#779 (comment)
This can be done as well and then the limit can just be disabled on the client side. However this is only a workaround as there is currently no better solution for #1642 |
I don't think just not storing receipts is a good solution. We could split them up instead of storing them as one large json, which would be better anyway, so that in the future we don't need to load the whole json when we just need a few receipts (like our own). Alternatively one of the approaches to increase the window size on android, since that seems to be the only platform with that problem. |
Well I never said this is a good solution or any solution at all. It is a workaround as any other solution would need such a huge change in all databases that it would make much more sense to do this once we have reduced the amount of databases in the sdk. But we cannot reduce the amount of databases as long as the new database is blocked by this edge case. So what solution would you suggest which does not need another weeks of development? |
Closed because I found a better solution |
thx |
Closes #1642