Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: throw more threads at dart test #1655

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

td-famedly
Copy link
Member

note: this probably does not help us a lot atm given that the base github runner is a 2 core vm

@td-famedly td-famedly force-pushed the td/throwMoreThreads branch 2 times, most recently from d87d002 to c04197c Compare December 19, 2023 18:05
@krille-chan
Copy link
Contributor

So if getconf _NPROCESSORS_ONLN returns 2 in the github runner, but the default value of --concurrency=<threads> is 4, this will mean that we reduce the amount of threads instead of throwing more threads at dart test. I don't think that this will help much :-/

@td-famedly
Copy link
Member Author

So if getconf _NPROCESSORS_ONLN returns 2 in the github runner, but the default value of --concurrency=<threads> is 4, this will mean that we reduce the amount of threads instead of throwing more threads at dart test. I don't think that this will help much :-/

Incorrect, the docs say. so right now it probably runs using 1 core? https://pub.dev/packages/test#test-concurrency

Test suites run concurrently by default, using half of the host's CPU cores.

@nico-famedly
Copy link
Member

With this change:

grafik

Without:

grafik

So I would say it made it faster?

scripts/test.sh Outdated Show resolved Hide resolved
@krille-chan
Copy link
Contributor

Incorrect, the docs say. so right now it probably runs using 1 core? https://pub.dev/packages/test#test-concurrency

This is the output of dart test --help:

-j, --concurrency=<threads>           The number of concurrent test suites run.
                                      (defaults to "4")

But it makes sense. Because I have 8 cores, the default is only for my machine. Sorry, I thought this "default" was meant globally :D

@td-famedly td-famedly force-pushed the td/throwMoreThreads branch 2 times, most recently from 1e5c737 to 43ba0a6 Compare December 20, 2023 13:15
@td-famedly td-famedly merged commit 6b66451 into main Dec 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants