Pass string to login method instead of LoginType for OIDC adaptation #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmcoding88
force-pushed
the
reza/oidc-login-flow
branch
from
d240292 to
b43f7b3
Compare
…tation. Breaking change: In order to call the login method users need to pass ```LoginType.loginType.name``` instead of ```LoginType.loginType```.
mrmcoding88
force-pushed
the
reza/oidc-login-flow
branch
from
b43f7b3 to
90aa446
Compare
|
This PR will be closed in favor of implementing an extension for OIDC login flow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: In order to call the login method users need to pass
LoginType.loginType.nameinstead ofLoginType.loginType.In order to adapt with OIDC login-flow we need to pass the string as type now since the OIDC login flow type is not a matrix type. Will be part of the work for https://github.com/famedly/product-management/issues/1563