Run spam checker callbacks for invites early during room creation #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nicolas Werner <[email protected]> Co-authored-by: Jan Christian Grünhage <[email protected]>
This allows clients to pass an extra parameter when refreshing a token, which overrides the configured refresh token timeout in the Synapse config. This allows a client to opt into a shorter (or longer) lifetime for their refresh token, which could be used to sign out web sessions with a specific timeout. Open questions are mostly if there should be a maximum refresh token lifetime someone could configure and if this should also be configurable on login. The latter doesn't seem as necessary, since a client can just refresh immediately after login (although that is racy). Once we figure out a nice behaviour for this, we should also write an MSC. For now this is just an experiment.
This prevents a partial room from being returned to clients. We can't currently validate all possible failure cases before sending out invites (since invites can fail for arbitrary reasons on the remote side). Additionally there are some other cases that might still create a partial room (alias length, third party callbacks, etc probably), that aren't covered by this change. Third-party invites are ignored as well. A proper fix to make the room creation atomic will most likely need spec changes. Signed-off-by: Nicolas Werner <[email protected]>
|
I guess this won't necessarily help, since for remote invites it is usually the remote user, who doesn't have us in their invite allow list... I guess for a single user invite, we could shutdown the room immediately... |
nico-famedly
force-pushed
the
master
branch
2 times, most recently
from
1a78f07 to
bd114ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a partial room from being returned to clients. We can't currently validate all possible failure cases before sending out invites (since invites can fail for arbitrary reasons on the remote side). Additionally there are some other cases that might still create a partial room (alias length, third party callbacks, etc probably), that aren't covered by this change. Third-party invites are ignored as well.
A proper fix to make the room creation atomic will most likely need spec changes.
See also https://github.com/famedly/product-management/issues/2385