Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add token validation helper #36

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

mzaniolo
Copy link
Contributor

Closes: #35

@mzaniolo mzaniolo force-pushed the mzaniolo/token_validation branch from fc148e3 to 20142c5 Compare November 20, 2024 13:31
Cargo.toml Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Show resolved Hide resolved
src/v2/token.rs Show resolved Hide resolved
@mzaniolo mzaniolo force-pushed the mzaniolo/token_validation branch from 20142c5 to d2da7e0 Compare November 20, 2024 14:22
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.45%. Comparing base (0795f7d) to head (c7b7074).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   12.23%   13.45%   +1.21%     
==========================================
  Files         132      133       +1     
  Lines        5164     5240      +76     
==========================================
+ Hits          632      705      +73     
- Misses       4532     4535       +3     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0795f7d...c7b7074. Read the comment docs.

Copy link

@nikzen nikzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one more claim

src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
@mzaniolo mzaniolo force-pushed the mzaniolo/token_validation branch 2 times, most recently from 739675a to 3ea9fb2 Compare November 21, 2024 15:55
@mzaniolo mzaniolo changed the title WIP - feat: Add token validation helper feat: Add token validation helper Nov 22, 2024
@mzaniolo mzaniolo marked this pull request as ready for review November 22, 2024 07:43
@mzaniolo mzaniolo requested a review from a team as a code owner November 22, 2024 07:43
@mzaniolo mzaniolo force-pushed the mzaniolo/token_validation branch from 3ea9fb2 to 9265ad8 Compare November 22, 2024 08:59
Copy link
Contributor

@sirewix sirewix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but few small unimportant stylistic suggestions, feel free to discard them

src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
@mzaniolo mzaniolo force-pushed the mzaniolo/token_validation branch 2 times, most recently from 814f7f4 to a42cb94 Compare November 22, 2024 15:54
@mzaniolo
Copy link
Contributor Author

LGTM, but few small unimportant stylistic suggestions, feel free to discard them

Thanks for the comments, I like your style.

src/v2/token.rs Outdated Show resolved Hide resolved
@mzaniolo mzaniolo force-pushed the mzaniolo/token_validation branch from a42cb94 to 229d7fd Compare November 22, 2024 16:38
sirewix
sirewix previously approved these changes Nov 22, 2024
@mzaniolo mzaniolo force-pushed the mzaniolo/token_validation branch 3 times, most recently from 7c45ba7 to 7cf1294 Compare November 25, 2024 07:51
sirewix
sirewix previously approved these changes Nov 25, 2024
src/v2/token.rs Outdated Show resolved Hide resolved
sirewix
sirewix previously approved these changes Nov 26, 2024
src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
src/v2/token.rs Outdated Show resolved Hide resolved
@mzaniolo mzaniolo merged commit c7b7074 into main Nov 26, 2024
5 checks passed
@mzaniolo mzaniolo deleted the mzaniolo/token_validation branch November 26, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement offline token validation helper
4 participants