Enable the config-store-lookup tests #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. What else is needed? |
elliottt
force-pushed
the
trevor/config-store-lookup
branch
from
a14020e to
f685837
Compare
GeeWee
pushed a commit
to GeeWee/Viceroy
that referenced
this pull request
Jul 25, 2024
The tests in cli/tests/integration/config_store_lookup.rs weren't being run because the module wasn't declared in cli/tests/integration/main.rs. I've re-enabled them, and copied the dictionary-lookup.rs test fixture to config-store-lookup.rs, to allow them to run successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in
cli/tests/integration/config_store_lookup.rsweren't being run because the module wasn't declared incli/tests/integration/main.rs. I've re-enabled them, and copied the dictionary-lookup.rs test fixture toconfig-store-lookup.rs, to allow them to run successfully.