⁉️ Switch to using the on-demand allocator, instead of the pooling allocator #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly, we've always used the pooling allocator: Lines 74 to 78 in f44257f Should we integrate the |
elliottt
reviewed
Jun 20, 2024
|
Ignore my comments about neeing a |
elliottt
reviewed
Jun 20, 2024
| @@ -90,7 +140,7 @@ impl ComponentCtx { | |||
| wasi: builder.build(), | |||
| session, | |||
| guest_profiler: guest_profiler.map(Box::new), | |||
| limiter: Limiter::default(), | |||
| limiter: Limiter::new(100, 100), | |||
There was a problem hiding this comment.
We'll need to change this, but I'm not too worried about it now as we're not officially supporting components yet.
GeeWee
pushed a commit
to GeeWee/Viceroy
that referenced
this pull request
Jul 25, 2024
…locator (fastly#391) Fixes fastly#255. In addition to just fixing fastly#255, this also allows the test suite to be run in parallel, again. At least on my machines, running `make test` directly would cause memory failures. I'm guessing this was due to the pooling allocator's use of virtual memory. Switching to the on-demand allocator means that things run fine. This extends the built-in `Limiter` object to use a `StoreLimits` under the hood, as suggested in the issue. It then builds different versions of this limiter based on whether or not Viceroy is operating in a component or non-component context, because component-based systems require more instances and more tables than traditional ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255.
In addition to just fixing #255, this also allows the test suite to be run in parallel, again. At least on my machines, running
make testdirectly would cause memory failures. I'm guessing this was due to the pooling allocator's use of virtual memory. Switching to the on-demand allocator means that things run fine.This extends the built-in
Limiterobject to use aStoreLimitsunder the hood, as suggested in the issue. It then builds different versions of this limiter based on whether or not Viceroy is operating in a component or non-component context, because component-based systems require more instances and more tables than traditional ones.