Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework component testing support to make test updates easier #395

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

elliottt
Copy link
Contributor

Add a macro for generating the core wasm and component versions of a test, and
modify the .adapt_component builder function on Test to accept a bool. This
simplifies modifying existing tests to support components by doing the work of
abstracting out the body in a macro.

@elliottt elliottt mentioned this pull request Jun 28, 2024
@elliottt elliottt requested a review from jameysharp June 28, 2024 20:14
Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this strikes me as a net positive for test clarity, in spite of my general preference to avoid macros. 👍

@elliottt elliottt merged commit 7b8c222 into main Jun 28, 2024
7 checks passed
@elliottt elliottt deleted the trevor/refactor-component-tests branch June 28, 2024 20:20
GeeWee pushed a commit to GeeWee/Viceroy that referenced this pull request Jul 25, 2024
)

Add a macro for generating the core wasm and component versions of a test, and
modify the .adapt_component builder function on Test to accept a bool. This
simplifies modifying existing tests to support components by doing the work of
abstracting out the body in a macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants