Remove some unused memory management code in the adapter #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/remove-unused-adapter-code
branch
from
455288a to
ba3a765
Compare
jameysharp
previously approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Because rustc has introduced new warnings from time to time, I'm always hesitant about introducing blanket deny(warnings) as it can mean that upgrading rustc breaks the build. I'm not sure whether to consider that a significant issue here; up to you!
Otherwise, this is clearly sensible. Ship it!
jameysharp
approved these changes
Jun 28, 2024
GeeWee
pushed a commit
to GeeWee/Viceroy
that referenced
this pull request
Jul 25, 2024
After fastly#394 there were some unused functions in the adapter that didn't fail in CI as we don't currently build the adapter in CI. This PR removes the unused code, and also builds the adapter in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #394 there were some unused functions in the adapter that didn't fail in
CI as we don't currently build the adapter in CI. This PR removes the unused
code, and also builds the adapter in CI.