Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for environment variables in the adapter #400

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

elliottt
Copy link
Contributor

@elliottt elliottt commented Jul 2, 2024

This copies over the implementation of environ_get and environ_sizes_get from the upstream adapter in wasmtime, and enables the environment variable test for components.

This copies over the implementation of `environ_get` and
`environ_sizes_get` from the upstream adapter in wasmtime, and enables
the environment variable test for components.
@elliottt elliottt marked this pull request as ready for review July 2, 2024 17:27
@elliottt elliottt requested review from acw and jameysharp July 2, 2024 17:27
Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me and it's nice to get more of the component tests running!

@elliottt elliottt merged commit 1de2be2 into main Jul 2, 2024
7 checks passed
@elliottt elliottt deleted the trevor/component-environment-vars branch July 2, 2024 19:05
GeeWee pushed a commit to GeeWee/Viceroy that referenced this pull request Jul 25, 2024
This copies over the implementation of `environ_get` and
`environ_sizes_get` from the upstream adapter in wasmtime, and enables
the environment variable test for components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants