Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downstream_server_ip_addr hostcall #401

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

ulyssa
Copy link
Contributor

@ulyssa ulyssa commented Jul 3, 2024

A customer noticed when trying to use the Rust SDK's Request::get_server_ip method that the downstream_server_ip_addr hostcall is not yet implemented in Viceroy. This PR adds support for it. I've also updated the SDK version used in the tests to be the latest release.

@ulyssa ulyssa force-pushed the ulyssa/server-ip-addr branch from 9413f4c to a576cdf Compare July 3, 2024 20:01
@ulyssa ulyssa force-pushed the ulyssa/server-ip-addr branch from a576cdf to ee08706 Compare July 3, 2024 21:13
@ulyssa ulyssa requested review from acw and elliottt July 3, 2024 21:13
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ulyssa ulyssa merged commit bf635be into main Jul 3, 2024
7 checks passed
@ulyssa ulyssa deleted the ulyssa/server-ip-addr branch July 3, 2024 23:54
GeeWee pushed a commit to GeeWee/Viceroy that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants