-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codeowners and basic PR template #1381
Conversation
.github/CODEOWNERS
Outdated
@@ -0,0 +1 @@ | |||
@fastly/developer-relations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i only added this team, is there a more inclusive one to add or others? @kpfleming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this repo (and also go-fastly
and terraform-provider-fastly
) the team name should be fastly/devex-engineering
.
I noticed that there isn't a PR template, i added one that's pretty basic for now, also happy to not include it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with the team name changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Maybe it makes sense to add the following sections as well:
- User impact
- Release considerations
All Submissions:
New Feature Submissions: