Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners and basic PR template #1381

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Conversation

anthony-gomez-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@@ -0,0 +1 @@
@fastly/developer-relations
Copy link
Contributor Author

@anthony-gomez-fastly anthony-gomez-fastly Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only added this team, is there a more inclusive one to add or others? @kpfleming

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this repo (and also go-fastly and terraform-provider-fastly) the team name should be fastly/devex-engineering.

@anthony-gomez-fastly
Copy link
Contributor Author

I noticed that there isn't a PR template, i added one that's pretty basic for now, also happy to not include it

Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the team name changed.

Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Maybe it makes sense to add the following sections as well:

  • User impact
  • Release considerations

@anthony-gomez-fastly anthony-gomez-fastly merged commit 082cb20 into main Jan 27, 2025
9 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the agomez-add-codeowners branch January 27, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants