refactor(language.rust): check wasmwasi target and return error if mismatched #1382
+55
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-gomez-fastly
force-pushed
the
CDTOOL-1004-support-rust-1.84
branch
6 times, most recently
from
5283bcd to
97ea81b
Compare
anthony-gomez-fastly
requested review from
kpfleming,
Integralist and
philippschulte
Integralist
previously approved these changes
Jan 30, 2025
|
LGTM, and I've approved the PR but we'll need either @kpfleming or @philippschulte to handle merging this PR and the subsequent new major release. |
philippschulte
previously approved these changes
Jan 30, 2025
| @@ -144,12 +147,17 @@ func (r *Rust) Dependencies() map[string]string { | |||
|
|
|||
| // Build compiles the user's source code into a Wasm binary. | |||
| func (r *Rust) Build() error { | |||
| var wasmWasiTarget = r.config.WasmWasiTarget | |||
| if wasmWasiTarget != RustWasmWasiTarget { | |||
| return fmt.Errorf("your WasmWasi target in your config was %s, please change it to %s", wasmWasiTarget, RustWasmWasiTarget) | |||
There was a problem hiding this comment.
This helps to get it compiled but maybe it should also list the other required compute project changes. I am not sure about that just something to think about. Also do we already have a public page with instructions or is this something we decided not to do anymore?
There was a problem hiding this comment.
good question, the vibe i was getting is that we generally don't expect people to provide their own configs and that they'll use the default. But it's good to check that assumption, i'll poke around
…smatched Breaking change to support Rust 1.84 and newer BREAKING CHANGE: Only the wasm32-waip1 build target is accepted if a non default config is provided
anthony-gomez-fastly
force-pushed
the
CDTOOL-1004-support-rust-1.84
branch
from
b9a2a4c to
c7c0910
Compare
anthony-gomez-fastly
dismissed stale reviews from Integralist and philippschulte
via
30cc440
anthony-gomez-fastly
force-pushed
the
CDTOOL-1004-support-rust-1.84
branch
from
30cc440 to
c7c0910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change to support Rust 1.84 and newer
BREAKING CHANGE:
Only the wasm32-waip1 build target is accepted if a non default config is provided
All Submissions:
New Feature Submissions:
Changes to Core Features:
Are there any considerations that need to be addressed for release?
this is a breaking change and will require a major version bump to prevent breakages