Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove artifact upload functionality #70

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Remove artifact upload functionality #70

merged 1 commit into from
Jan 15, 2025

Conversation

kailan
Copy link
Member

@kailan kailan commented Jan 15, 2025

This behaviour is not used and is broken in the current release. It also allows us to reduce the size of the distributed JS significantly as it removes two dependencies. Resolves #64.

@kailan kailan requested review from a team and kpfleming and removed request for a team January 15, 2025 12:43
@kailan kailan merged commit 6127cc8 into main Jan 15, 2025
9 checks passed
@kailan kailan deleted the artifact-upload branch January 15, 2025 14:33
@geemus
Copy link

geemus commented Jan 15, 2025

Thanks, glad to see this fixed. Can we expect a tag/release soon as well?

@kailan
Copy link
Member Author

kailan commented Jan 16, 2025

Thanks, glad to see this fixed. Can we expect a tag/release soon as well?

No problem, thanks for your patience, I understand it was reported a while ago.

I've opened #71 to make a new release and hope to get that out today.

@geemus
Copy link

geemus commented Jan 16, 2025

Thanks, I appreciate it.

I'll watch #71 for the release so we can get try that and hopefully get everything up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v10 artifact.create is not a function
3 participants