generate individual c++ makefiles in target dir #47801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkarneges
force-pushed
the
jkarneges/makefiles-in-target
branch
from
b20f9c3 to
56d508a
Compare
sima-fastly
approved these changes
Nov 27, 2023
| /src/runner/certs/*.crt | ||
| /src/runner/certs/*.key | ||
| /postbuild/conf.pri |
There was a problem hiding this comment.
if we want all conf.pri files to be ignore we can add conf.pri once in .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates the c++ makefiles in the target dir rather than under src/cpp, so no files are written under src/cpp during build, and so
cargo cleanwill remove all intermediate build files including generated makefiles. As a further simplification, the makefiles are generated individually via multiple qmake invocations rather than by relying on a qmake subdirs project. Also fix make install and move the location of postbuild's pri file to avoid warnings when running make clean.