Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy req session zhttpReq readyread disconnect fix #47820

Closed
wants to merge 1 commit into from

Conversation

sima-fastly
Copy link
Contributor

@sima-fastly sima-fastly commented Dec 6, 2023

proxy req session zhttpReq readyread disconnect fix
the disconnect needs to happen per request

tested locally

@sima-fastly sima-fastly self-assigned this Dec 6, 2023
@sima-fastly sima-fastly marked this pull request as ready for review December 6, 2023 23:37
@sima-fastly sima-fastly requested a review from jkarneges December 6, 2023 23:37
@jkarneges
Copy link
Member

Hmm, I don't think this code needs to track multiple connections since there is only one inner ZhttpRequest per RequestSession.

@sima-fastly
Copy link
Contributor Author

Hmm, I don't think this code needs to track multiple connections since there is only one inner ZhttpRequest per RequestSession.

that's a great point! no need for this update then.
ill be closing this PR

@sima-fastly sima-fastly closed this Dec 7, 2023
@sima-fastly sima-fastly deleted the sima/boost-requestsession-fix branch December 7, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants