Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new parser's use of aliases revealed some alias-related bugs in some of the optimizations. The cleanest fix for this is to just remove
ValueData::Alias
, and instead replace the uses of the aliasValue
with the originalValue
(which is easy, because the dfg already tracks which instructions use eachValue
.)I also changed the parser so that it no longer uses aliases. The prior method of handling values in the parser lead to the wrong type being assigned to some insn result values (in cases where the first argument to some insn was a value whose definition had not yet been seen by the parser). The new method is to first do a pass over all statements in a function to "declare" all values with their proper types (by calling
dfg.make_value
with dummyValueData
).