Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ir module linking #96

Merged
merged 13 commits into from
Dec 6, 2024
Merged

Ir module linking #96

merged 13 commits into from
Dec 6, 2024

Conversation

Y-Nak
Copy link
Collaborator

@Y-Nak Y-Nak commented Dec 4, 2024

This PR adds an IR-level module linking support.

Also added some changes below:

  • Remove ValueVisitable and add Visitable/VisitableMut and Visitor/VisitorMut, #[inst(value)] attribute is no longer required to define an instruction
  • Require ; at the end of the global declaration for consistency
  • Omit -> unit when dumping a function signature in text format.
  • Remove the sig field from Function because of meaningless duplication(and only ModuleCtx owns it now).

@Y-Nak
Copy link
Collaborator Author

Y-Nak commented Dec 4, 2024

Maybe, it'd be better to move module_linker to ir crate(it's trivial, though). Do you have any thoughts? @sbillig

@Y-Nak
Copy link
Collaborator Author

Y-Nak commented Dec 5, 2024

@sbillig I moved module_linkerto ir crate.

@Y-Nak Y-Nak mentioned this pull request Dec 6, 2024
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbillig sbillig merged commit 52551c8 into fe-lang:main Dec 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants