Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization: Eliminate render-blocking resources #4172

Closed
rfultz opened this issue Nov 5, 2020 · 1 comment · May be fixed by #4604
Closed

Optimization: Eliminate render-blocking resources #4172

rfultz opened this issue Nov 5, 2020 · 1 comment · May be fixed by #4604
Assignees

Comments

@rfultz
Copy link
Contributor

rfultz commented Nov 5, 2020

Background

Looking to optimize the site's performance and that of the homepage specifically, the Lighthouse tool in Chromium browsers has made some suggestions. Some of these will have repercussions throughout the app so we're going to make them their own tickets.

Recommendation: Eliminate render-blocking resources

Resources are blocking the first paint of your page. Consider delivering critical JS/CSS inline and deferring all non-critical JS/styles. details

Overview

We could embed the content of our CSS and JS files into the page rather than linking to them

Benefit (the 80 of 80/20)

Minimal

Effort (the 20 of 80/20)

Likely minimal

Complications

  • Possible security complications? Thinking about the sandbox between in-page <script> and <script src="…">. Check into CORS rules
  • Would want to make sure we aren't affecting templates unexpectedly
  • Could affect script load timing and race conditions, like with a <script async defer> in the head (which would load last) vs putting all that code into the page right then

Related tickets

This was referenced Nov 5, 2020
@rfultz rfultz self-assigned this May 6, 2021
@rfultz rfultz added this to the PI 14 Innovation milestone May 19, 2021
@rfultz rfultz removed this from the PI 14 Innovation milestone Jun 7, 2021
@rfultz rfultz added this to the Sprint 15.2 milestone Jun 7, 2021
@patphongs patphongs modified the milestones: Sprint 15.2, Sprint 15.3 Jun 16, 2021
@lbeaufort lbeaufort removed this from the Sprint 15.3 milestone Jul 8, 2021
@JonellaCulmer
Copy link
Contributor

Closing this ticket while we wrap up the webpack work. #2708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants