-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update boolean search box and add tooltips for AO,MUR, Statutes #2574
Conversation
@JonellaCulmer --There are still two minor design issues with this PR that I did not want to hold up the PR getting merged for testing.
|
Thanks for the heads up, @johnnyporkchops! |
@johnnyporkchops I can review and approve this, or were you going to try to implement the other stuff before review/merge. Happy to do it either way. Up to you. |
Codecov Report
@@ Coverage Diff @@
## develop #2574 +/- ##
===========================================
- Coverage 74.98% 74.97% -0.01%
===========================================
Files 115 115
Lines 6971 6970 -1
Branches 599 599
===========================================
- Hits 5227 5226 -1
Misses 1744 1744
Continue to review full report at Codecov.
|
@JonellaCulmer. I pushed fix for outstanding checklist item 1 above. Here are screenshots of how the tooltips render now for this branch (not updated on feature space yet). The one on the AO Page:MUR Page overlap issue:MUR Page w/ overlap fixed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical changes look good to me. @JonellaCulmer Once you complete your design review, please go ahead and merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks wonderful, @johnnyporkchops! Thanks for all your hard work on this!
Summary
Make design/layout edits to keyword modal html and jinja templates
Add tooltip for keyword text-box field on AO, MUR, Statues
AO Search is React.js, so I made the tooltip in here, a reusable react component (Could now be
used on any filter type inside AO search with custom tooltip message and positioning classes)
MUR and Statutes datatables are both rendered from legal.jinja, so the tooltip is hardcoded there
Resolves Update boolean search box and add tooltip #2283
Impacted areas of the application
AO Search react app
- modified: fec/static/js/legal/Filters.js
- modified: fec/static/js/legal/filters/TextFilter.js
- added: fec/static/js/legal/filters/TooltipHelp.js
MUR and Statutes datatables:
- modified: legal/templates/macros/legal.jinja
- modified: fec/static/scss/components/_tooltips.scss
Keyword Modal popup:
- modified: home/templates/partials/legal-keyword-modal.html
- modified: legal/templates/partials/legal-keyword-modal.jinja
- modified: fec/static/scss/components/_search-controls.scss
- modified: fec/static/scss/components/_modals.scss
Screenshots
Tested in Internet Explorer below, per checklist item 5 in issue:
How to test
Checkout this branch locally: feature/update-boolean-search-box
NPM run build
Runserver and test the tooltips on Keyword text filter on AO, MUR and Statutes searches
Test keyword modal box on the same pages as well as the legal landing page (this uses a different template)
If one were ambitious they could also test the reusable tooltip react component by adding it to
DateFilter.js
* by:TextFilter.js
file:...and pasting it into
DateFilter.js
.Filters.js
for that filter-type (DateFilter), like I did for the TextFilter (@line 56). Maybe add a different message.*For filters that depend on other filters, like CheckboxFiler, the process is different, but it can still be added to any filter in the panel.