[MERGE WITH GITFLOW] Fix Safari bug with desktop-size menu #4495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyporkchops
changed the title
rfultz
reviewed
Mar 18, 2021
patphongs
approved these changes
Mar 18, 2021
johnnyporkchops
changed the title
[Adding to hotfix branch] Fix filter when results have `{` or `}`
Codecov Report
@@ Coverage Diff @@
## master #4495 +/- ##
==========================================
+ Coverage 75.78% 75.83% +0.05%
==========================================
Files 122 123 +1
Lines 7511 7523 +12
Branches 605 605
==========================================
+ Hits 5692 5705 +13
+ Misses 1819 1818 -1
Continue to review full report at Codecov.
|
This was referenced Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
tabindex=0to desktop menu links to make Mega Menu work in Safari. Thosetabindexattributed were removed as part of ARIA/accessibility fixes for mobile menu and search/typeahead #4456 to resolve the Lighthouse flag for[aria-hidden="true"] elements contain focusable descendantsondiv#site-menu.site-nav__container. This was fine in other browsers but made the menu inoperable in Safari.According to the documentation for Accessible-Mega Menu Keyboard Accessibility docs, these tabindexes are necessary, however they are not in the source code on the GH repo.
Followup work:
elements contain focusable descendantserror. Need to verify by having a few different people do a Lighthouse accessibility scan for mobile/desktopImpacted areas of the application
modified: fec/templates/partials/navigation/navigation.html
How to test
hotfix/4494-safari-menu-bug