Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4188 Change maximum-scale to 5 #4583

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented May 3, 2021

Summary

Lighthouse gave us accessibility guidance that our maximum-scale was 1 and should be 5+. So I changed it to 5. This should let mobile users zoom into our pages (up to 5x)

Required reviewers

A couple who can review front-end usage (not code, but usage).

Impacted areas of the application

Will affect every page of the site, though likely only for mobile.

Screenshots

No visible changes, but look at this:
image

Related PRs

None

How to test

  • Pull the branch
  • ./manage.py runserver
  • Make sure pages load normally and don't look too zoomed (in or out)

Will need to check on a mobile device from feature, dev, and/or stage
Make sure pages:

  • load at the right size
  • can scale/zoom/unpinch,
  • pinch back down to 100% device width (if they go smaller, they should relax back to 100%)
    • Safari (mobile)
    • Chrome (mobile)
    • Firefox (mobile)
    • Internet (mobile, Android)

Copy link
Contributor

@johnnyporkchops johnnyporkchops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rfultz, tested in stage. Looks when I pinch to zoom and then double tap to zoom back to 100%, it goes back correctly. On production, it zooms in slightly more than needed on the double tap to zoom back out.

@patphongs patphongs merged commit e206c65 into develop May 4, 2021
@lbeaufort lbeaufort deleted the feature/4188-maximum-scale branch June 22, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimization (accessibility): [user-scalable="no"] or [maximum-scale] attribute is less than 5
3 participants