5680 Sass linter

.stylelintrc.json

@@ -0,0 +1,40 @@
+{
+  "extends": ["stylelint-config-standard-scss", "stylelint-config-css-modules"],
+  "plugins": ["stylelint-scss"],
+  "rules": {
+    "at-rule-empty-line-before": null,
+    "color-named": "never",
+    "declaration-block-no-redundant-longhand-properties": null,
+    "declaration-colon-space-after": "always",
+    "font-family-no-missing-generic-family-keyword": null,
+    "no-descending-specificity": null,
+    "no-duplicate-selectors": null,
+    "no-eol-whitespace": true,
+    "property-no-vendor-prefix": null,
+    "rule-empty-line-before": null,
+    "scss/at-extend-no-missing-placeholder": null,
+    "scss/comment-no-empty": null,
+    "scss/dollar-variable-pattern": null,
+    "scss/double-slash-comment-empty-line-before": null,
+    "scss/double-slash-comment-whitespace-inside": null,
+    "scss/function-no-unknown": null,
+    "scss/no-global-function-names": null,
+    "selector-class-pattern": null
+  },
+  "TODO: remove these overrides as we move toward industry standards": [
+    "at-rule-empty-line-before",
+    "declaration-block-no-redundant-longhand-properties",
+    "declaration-colon-space-after",
+    "font-family-no-missing-generic-family-keyword",
+    "no-descending-specificity",
+    "no-duplicate-selectors",
+    "rule-empty-line-before",
+    "scss/at-extend-no-missing-placeholder",
+    "scss/comment-no-empty",
+    "scss/dollar-variable-pattern",
+    "scss/double-slash-comment-whitespace-inside",
+    "scss/function-no-unknown",
+    "scss/no-global-function-names",
+    "selector-class-pattern"
+  ]
+}

.vscode/extensions.json

@@ -0,0 +1,3 @@
+{
+  "recommendations": ["stylelint.vscode-stylelint"]
+}

fec/data/templates/partials/warnings.jinja

@@ -7,7 +7,7 @@
   </div>
 </noscript>
 
-<div id="ie_warning" style="display: none;">
+<div id="ie-warning" style="display: none;">
   <h2>Your web browser is not supported</h2>
   <p>You&apos;re using Internet Explorer, some features might not work. Please switch to another browser like Chrome, Firefox, or Edge for a better experience.</p>
 </div>

fec/fec/static/scss/components/_accordions.scss

@@ -29,10 +29,11 @@
 
 .accordion__button {
   @include u-icon-bg($plus-circle, $primary);
+
   background-size: u(2rem);
   background-position: 95% 50%;
   border-bottom: 1px solid $base;
-  margin: 0 0 -1px 0;
+  margin: 0 0 -1px;
   color: $base;
   font-size: u(1.4rem);
   font-weight: bold;
@@ -43,15 +44,17 @@
 
   &[aria-expanded='true'] {
     @include u-icon-bg($minus-circle, $primary);
+
     border-bottom: none;
   }
 
   &.email__button {
     padding: u(1rem 4rem 1rem 1rem);
     &::before {
-      content:'';
+      content: '';
       @extend .button--envelope;
-      padding: u(1rem 0rem 1rem 0);
+
+      padding: u(1rem 0 1rem 0);
     }
   }
 
@@ -64,7 +67,8 @@
 }
 
 .accordion__content {
-  @include clearfix();
+  @include clearfix;
+
   border-bottom: 1px solid $base;
   padding: u(2rem);
   font-family: $sans-serif;
@@ -112,6 +116,7 @@
 .accordion--inverse {
   .accordion__button {
     @include u-icon-bg($plus-circle, $inverse);
+
     background-position: 100% 50%;
     border-color: $inverse;
     color: $inverse;
@@ -123,6 +128,7 @@
 
   .accordion__content {
     @include u-font-color($inverse);
+
     border-color: $inverse;
   }
 }

fec/fec/static/scss/components/_agendas.scss

@@ -33,6 +33,7 @@
 
     &::before {
       @include heading(h3);
+
       position: absolute;
       left: 0;
       top: 0;
@@ -46,6 +47,7 @@
 
     &::before {
       @include u-icon($document, $base, 3rem, 3rem, 50%);
+
       background-position: 0 50%;
       content: '';
       display: inline-block;
@@ -84,6 +86,7 @@
 
   &::before {
     @include u-icon($document, $base, 3rem, 3rem, 50%);
+
     background-position: 0 50%;
     content: '';
     display: inline-block;
@@ -106,8 +109,8 @@
     left: 0;
     right: 0;
     bottom: 0;
-    width:100%;
-    height:100%;
+    width: 100%;
+    height: 100%;
   }
 }
 

fec/fec/static/scss/components/_articles.scss

@@ -22,15 +22,15 @@
   }
 
   .block-paragraph + .block-table {
-     margin-top: u(-4rem);
-    }
+    margin-top: u(-4rem);
+  }
 
 }
-  .block-table {
-    table {
-      @extend .simple-table-cms;
-    }
+.block-table {
+  table {
+    @extend .simple-table-cms;
   }
+}
 
 
 
@@ -80,6 +80,7 @@
 
 .icon--email--author {
   @extend .icon--inline--right;
+
   margin-left: u(.5rem);
   max-width: 20px;
 
@@ -109,6 +110,7 @@
 
   .read_next__image__container {
     @include span-columns(3);
+
     display: block;
   }
 }

fec/fec/static/scss/components/_breadcrumbs.scss

@@ -28,7 +28,8 @@
 }
 
 .breadcrumbs__item {
-  @include u-truncate();
+  @include u-truncate;
+
   float: left;
   max-width: u(20rem);
   padding: u(.8rem 0);

fec/fec/static/scss/components/_breakdowns.scss

@@ -26,6 +26,6 @@
 
 }
 .bar-container {
-      margin-left: 0;
-      background: $gray-lightest;
-    }
+  margin-left: 0;
+  background: $gray-lightest;
+}