Sass Deprecation Warnings #6422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6422 +/- ##
========================================
Coverage 79.72% 79.72%
========================================
Files 235 235
Lines 5159 5159
========================================
Hits 4113 4113
Misses 1046 1046 ☔ View full report in Codecov by Sentry. |
johnnyporkchops
requested review from
johnnyporkchops
and removed request for
johnnyporkchops
18 tasks
johnnyporkchops
requested changes
Jan 21, 2025
|
|
||
| /* as a necessity, we depart from mobile-first(min-width only MQs) here for these tables only */ | ||
| @media only screen and (width <= 650px), | ||
| (device-width >= 650px) and (device-width <= 1024px) { |
There was a problem hiding this comment.
@rfultz I am not sure if this iis where the issue is, but the responsive mobile styles for these tables no longer works on this branch
There was a problem hiding this comment.
Nice catch!
For the record, width <= doesn't seem to work but the older max-width: does
fec/fec/static/scss/_global.scss
Outdated
| @import 'components/search-bar'; | ||
| @import 'components/site-header'; | ||
|
|
||
| body:before { |
There was a problem hiding this comment.
@rfultz Dont forget this
johnnyporkchops
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressing Sass deprecation and, while adjusting everything, added some Sass formatting
Required reviewers
Impacted areas of the application
The entire front-end, but most changes hit mixins and seemed to mostly fall on
Screenshots
Should be zero visual changes
No longer getting screen after screen of deprecation warnings!
Related PRs
None
How to test
npm inpm run build./manage.py runserver