-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6416-upgrade Wagtail to 6.3 #6641
base: develop
Are you sure you want to change the base?
Conversation
I like the two added features of setting a date for a page to be published and the content metrics for the pages. I have just started my review, but wanted to note these two new features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good to me. Thanks!
@cnlucas One small change... The CSS for our custom RichText Editor features is not rendering because we need to change Deprecated in 5.1 and removed in 6 fec-cms/fec/fec/wagtail_hooks.py Line 136 in aa852a8
Also, I agreed with checklist item above about the keeping copy view enabled for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, left a small comment #6641 (comment)
Summary (required)
Upgrades to Wagtail 6.3 (LTS)
Relevant changes in Wagtail 6.0
Changes for users
Adds support for Django 5.0 (still supports 4.2)
Wagtail 6.0 has removed the ModelAdmin app
Query model moved to wagtail.contrib.search_promotions
Support for ES 5/6 dropped
StreamField no longer requires use_json_field=True (https://docs.wagtail.org/en/stable/releases/6.0.html#streamfield-no-longer-requires-use-json-field-true)
The wagtail.tests.utils module has been removed and can now be found at wagtail.test.utils.
SnippetViewSet & ModelViewSet copy view enabled by default
Helpful guide here: https://learnwagtail.com/blog/upgrading-to-wagtail-6-0/
Required reviewers
3-4 reviewers (FE and at least one content)
Impacted areas of the application
General components of the application that this PR will affect:
Screenshots
Universal search
How to test
-gh pr checkout 6641
-pyenv virtualenv 3.10.14 cms_new
-pyenv activate cms_new
-pip install -r requirements.txt
-pip install -r requirements-dev.txt
-npm i && npm run build
-dropdb cfdm_cms_test
-createdb cfdm_cms_test
restore latest cms db dump
(get dump from shared folder, 'pg_restore --dbname cfdm_cms_test --no-acl --no-owner PATH')
-cd fec
-python manage.py migrate
-python manage.py createsuperuser
-python manage.py runserver
-pytest
Please try making multiple types of pages, searching for a page, creating & deleting...