Add test case in CandidateTotalAggregateView

[fec-jli]

Summary (required)

After create new endpoint: /candidates/totals/aggregates/, we need add test cases.

• Resolves Add test case in /candidates/totals/aggregates/ #5092
• Ref PR Add endpoint /candidates/totals/aggregates/ #5090

Required reviewers

1 developer

Impacted areas of the application

endpoint: /candidates/totals/aggregates/

Completion criteria

• Add test case in endpoint
• pass pytest
• Add one more filter: district
• Fix deprecated function from query.add_colum() to query.add_colums()
• Change endpoint name from /candidates/totals/aggregate/ to /candidates/totals/aggregates/

How to test

• Checkout branch, point to dev db
• pytest
• test endpoint /candidates/totals/aggregates/ by passing each aggregate_by parameter.

[cnlucas]

@fec-jli, pytest passed for me. I'm having some issues accessing the data. A few small items that might be helpful, but are not really about the test.

1. Required fields perhaps should be marked with a *required
2. Integer is being shown as $int32 for the first several filters
3. Perhaps making the election_full description a bit more clear

The test looks great and the updates to the names look good. I'm so impressed with your hard work and skill.

[fec-jli]

@fec-jli, pytest passed for me. I'm having some issues accessing the data. A few small items that might be helpful, but are not really about the test.

1. Required fields perhaps should be marked with a *required
2. Integer is being shown as $int32 for the first several filters
3. Perhaps making the election_full description a bit more clear

The test looks great and the updates to the names look good. I'm so impressed with your hard work and skill.

@cnlucas Thank you for your review and comments.

1. There is no required field for this endpoint.
2. When we define the field type = fields.Int, it will show $int32 which means 32 bits integer type, not big integer. this affect all endpoints.
3. I agree the election_full description is obscure. Could you create a ticket to address this? All endpoints share the election_full description now.
   Thanks.

[cnlucas]

Thanks @fec-jli, will create the ticket for the election_full.

[hcaofec]

Should the party filter be removed since the logic is not in resource yet?

[codecov-commenter]

Codecov Report

Merging #5099 (3345212) into develop (75007c6) will increase coverage by 0.57%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #5099      +/-   ##
===========================================
+ Coverage    85.17%   85.75%   +0.57%     
===========================================
  Files           81       81              
  Lines         7719     7713       -6     
===========================================
+ Hits          6575     6614      +39     
+ Misses        1144     1099      -45     

Impacted Files	Coverage Δ
webservices/args.py	97.81% <ø> (ø)
webservices/docs.py	100.00% <100.00%> (ø)
webservices/resources/candidate_aggregates.py	98.17% <100.00%> (+27.24%)	⬆️
webservices/rest.py	90.58% <100.00%> (-0.56%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75007c6...3345212. Read the comment docs.

[hcaofec]

Great work on this endpoint!