Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

210 combine plot types into a single figure #224

Merged
merged 6 commits into from
Feb 10, 2025
Merged

210 combine plot types into a single figure #224

merged 6 commits into from
Feb 10, 2025

Conversation

JavierCladellas
Copy link
Collaborator

@JavierCladellas JavierCladellas commented Feb 5, 2025 •
edited
Loading

Screenshot 2025-02-05 at 14 29 59

Users can now switch between tabs depending on the figure types from config
Done:

  • Updated the figures template
  • Add custom css for figures
  • MVC logic changed, there is more handled by the template.
  • Split js code into separate file
  • Allow horizontal scrolling on parameters table

@JavierCladellas JavierCladellas added enhancement A new feature or request visualization Issues related to visualization reporting Issues related to reporting data-visualization Creating visual representations of data labels Feb 5, 2025
@JavierCladellas JavierCladellas self-assigned this Feb 5, 2025
@JavierCladellas JavierCladellas linked an issue Feb 5, 2025 that may be closed by this pull request
combine plot_types into a single figure #210
Closed
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for benchmarking-polite-crostata-92f389 ready!

Name Link
🔨 Latest commit f4b9a13
🔍 Latest deploy log https://app.netlify.com/sites/benchmarking-polite-crostata-92f389/deploys/67a9cdc78861190008e1490e
😎 Deploy Preview https://deploy-preview-224--benchmarking-polite-crostata-92f389.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JavierCladellas JavierCladellas marked this pull request as ready for review February 5, 2025 13:32
@vincentchabannes vincentchabannes merged commit c3fd403 into master Feb 10, 2025
10 checks passed
@vincentchabannes vincentchabannes deleted the 210-combine-plot_types-into-a-single-figure branch February 10, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentchabannes vincentchabannes vincentchabannes approved these changes

@prudhomm prudhomm Awaiting requested review from prudhomm

Assignees

@JavierCladellas JavierCladellas

Labels
data-visualization Creating visual representations of data enhancement A new feature or request reporting Issues related to reporting visualization Issues related to visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

combine plot_types into a single figure
2 participants
@JavierCladellas @vincentchabannes