addpkg: libepoxy #1397
Merged
addpkg: libepoxy #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XieJiSS
reviewed
Jun 14, 2022
| -source=("git+https://github.com/anholt/libepoxy#commit=$_commit") | ||
| -sha256sums=('SKIP') | ||
| +source=("git+https://github.com/anholt/libepoxy#commit=$_commit" | ||
| + "$pkgname-dlwrap-riscv64.patch::https://github.com/anholt/libepoxy/pull/270.patch") |
There was a problem hiding this comment.
Just wondering, are similar patches necessary for other glibc versions, e.g. 2.26?
There was a problem hiding this comment.
No. libdl has different glibc ABI version for each architecture (e.g. rv64 has the version GLIBC_2.27, see sysdeps/unix/sysv/linux/riscv/rv64/libdl.abilist in glibc's source), and it's not likely to update frequently. libepoxy uses a wrapper for dlsym(), which search through the hard-coded versions (link) to resolve dlsym() provided by libdl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a wrapper for
dlsym()in test, which hard-coded the glibc ABI version that libdl uses.Upstream PR: anholt/libepoxy#270