Fixing a bug with mosh links. (#407)

FluentTerminal.App/Dialogs/SshInfoDialog.xaml.cs

@@ -63,8 +63,6 @@ public SshInfoDialog(ISettingsService settingsService, ISshHelperService sshHelp
             {
                 TerminalThemes.Add(theme);
             }
-
-
         }
 
         private void SetupFocus()

FluentTerminal.App/Services/SshHelperService.cs

@@ -147,7 +147,7 @@ public ISshConnectionInfo ParseSsh(Uri uri)
                     if (match.Success)
                     {
                         vm.MoshPortFrom = ushort.Parse(match.Groups["from"].Value);
-                        vm.MoshPortFrom = ushort.Parse(match.Groups["to"].Value);
+                        vm.MoshPortTo = ushort.Parse(match.Groups["to"].Value);
                     }
 
                     continue;
@@ -235,6 +235,8 @@ public string ConvertToUri(ISshConnectionInfo sshConnectionInfo)
                 sb.Append(sshConnectionInfoVm.SshPort.ToString("#####"));
             }
 
+            sb.Append("/");
+
             bool queryStringAdded = false;
 
             if (sshConnectionInfoVm.UseMosh)

FluentTerminal.Models/ShellProfile.cs

@@ -78,10 +78,10 @@ public virtual bool EqualTo(ShellProfile other)
 
             return other.Id.Equals(Id)
                    && other.PreInstalled.Equals(PreInstalled)
-                   && other.Name.Equals(Name)
-                   && other.Arguments.Equals(Arguments)
-                   && other.Location.Equals(Location)
-                   && other.WorkingDirectory.Equals(WorkingDirectory)
+                   && other.Name.NullableEqualTo(Name)
+                   && other.Arguments.NullableEqualTo(Arguments)
+                   && other.Location.NullableEqualTo(Location)
+                   && other.WorkingDirectory.NullableEqualTo(WorkingDirectory)
                    && other.TabThemeId.Equals(TabThemeId)
                    && other.TerminalThemeId.Equals(TerminalThemeId)
                    && other.LineEndingTranslation == LineEndingTranslation

FluentTerminal.Models/SshProfile.cs

@@ -69,12 +69,11 @@ public override bool EqualTo(ShellProfile other)
                 return true;
             }
 
-            return string.Equals(otherSsh.Host, Host)
+            return otherSsh.Host.NullableEqualTo(Host)
                    && otherSsh.SshPort.Equals(SshPort)
-                   && string.Equals(otherSsh.Username, Username)
-                   && (string.IsNullOrEmpty(IdentityFile)
-                       ? string.IsNullOrEmpty(otherSsh.IdentityFile)
-                       : string.Equals(otherSsh.IdentityFile, IdentityFile)) && otherSsh.UseMosh.Equals(UseMosh)
+                   && otherSsh.Username.NullableEqualTo(Username)
+                   && otherSsh.IdentityFile.NullableEqualTo(IdentityFile)
+                   && otherSsh.UseMosh.Equals(UseMosh)
                    && otherSsh.MoshPortFrom.Equals(MoshPortFrom)
                    && otherSsh.MoshPortTo.Equals(MoshPortTo);
         }

FluentTerminal.Models/StringExtensions.cs

@@ -0,0 +1,12 @@
+namespace FluentTerminal.Models
+{
+    public static class StringExtensions
+    {
+        /// <summary>
+        /// Compares two strings for equality, but assumes that null string is equal to an empty string.
+        /// </summary>
+        public static bool NullableEqualTo(this string original, string other) => string.IsNullOrEmpty(original)
+            ? string.IsNullOrEmpty(other)
+            : original.Equals(other);
+    }
+}