Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created docusaurus-spin template repository to Spin Up Hub #1098

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

VamshiReddy02
Copy link
Contributor

@VamshiReddy02 VamshiReddy02 commented Dec 15, 2023

This PR adds the spin-docusaurus template repository to the Spin Up Hub. I'm sorry for closing my Last PR because of some technical issues. All the requested changes have been made. please let me know if there are any further changes to be made.

Fixes issues: #801

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date` are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep '^M' | wc -l and expect 0 as a result)
  • Has passed bart check

✅ content/api/hub/template_docusaurus.md

  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)

Screenshot 2023-12-18 at 11 13 46

  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

@VamshiReddy02
Copy link
Contributor Author

@tpmccallum please review this PR, and let me know if there are any additional modifications required.

Copy link
Contributor

@tpmccallum tpmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @VamshiReddy02
Thanks for the contribution.
Champion!!!

@tpmccallum tpmccallum merged commit 4ae2fa1 into fermyon:main Dec 18, 2023
3 checks passed
@VamshiReddy02 VamshiReddy02 deleted the docusaurus-spin branch December 19, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants