Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new supported car Dacia Spring #750

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

iboboc
Copy link

@iboboc iboboc commented May 26, 2022

Add new supported car Dacia Spring
Added Romanian language and prepare for italian

iboboc added 2 commits May 26, 2022 17:37
Added Romanian language and prepare for italian
Fix a crash in Battery view for Spring only
Fix instant consumption view for Spring
@iboboc iboboc closed this May 26, 2022
@iboboc iboboc reopened this May 26, 2022
@iboboc
Copy link
Author

iboboc commented May 27, 2022

CanZE build with this changes has been fully tested on Dacia Spring and all features are working as expected. Not tested on Renault Zoe, but changes has been made without impacting existing code.

@fesch
Copy link
Owner

fesch commented Jun 9, 2022

I didn't have the time yet to check this (heavy period at school right now ;-)) but it is not forgotten!!!

@flyser
Copy link

flyser commented Apr 28, 2023

Hi @iboboc,
The CSV files seem to be a bit broken. Where did you get this data from or did you just copy it from the zoe? I tried

,7bb,24,39,.000976563,0,3,V,229254,629254,ff,cell minimal voltage 20ms Wxx_cell_v_min_20ms,
,7bb,24,39,.000976563,0,3,V,229255,629255,ff,cell minimal voltage 20ms Wxx_cell_v_max_20ms,

from LBC_Fields.csv and the vehicle responded with a negative response code.
also

,7bb,24,39,.000976563,0,3,V,229007,629007,ff,Maximum Cell VoltageWxx_cell_v_max,
,7bb,24,39,.000976563,0,3,V,229009,629009,ff,Minimum Cell VoltageWxx_cell_v_min,

from the same file gives a response, but it rather looks like some cell voltages instead of min&max, because sometimes the max can be lower than the min.

Could you also check the comma separators in these files? seems like there is one missing e.g. before "Wxx_cell_v_min" in the example above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants