Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up: adding status field for Application #117

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Follow up: adding status field for Application #117

merged 1 commit into from
Oct 17, 2023

Conversation

portega-adv
Copy link
Contributor

Follow-up of PR#114 to add status for Application object.

We've took the work from the original author, added tests and improvements as per Øyvind's review.

@oyvindio @mika-hjalmarsson

@portega-adv portega-adv requested a review from a team as a code owner October 11, 2023 12:35
@portega-adv portega-adv requested a review from a team October 13, 2023 07:25
oyvindio
oyvindio approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@oyvindio oyvindio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated changes look good to me 👍

@portega-adv portega-adv merged commit a864f3e into master Oct 17, 2023
@portega-adv portega-adv deleted the add_status_endpoint_followup branch October 17, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herodes1991 herodes1991 herodes1991 approved these changes

@imorato imorato imorato approved these changes

@oyvindio oyvindio oyvindio approved these changes

@mortenlj mortenlj Awaiting requested review from mortenlj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@portega-adv @oyvindio @imorato @herodes1991