feat: actor state accessors: Add accessors to DealState.SectorNumber #11936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexLuthr
approved these changes
Apr 30, 2024
rvagg
approved these changes
May 3, 2024
rvagg
reviewed
May 16, 2024
| SectorStartEpoch abi.ChainEpoch // -1 if not yet included in proven sector | ||
| LastUpdatedEpoch abi.ChainEpoch // -1 if deal state never updated | ||
| SlashEpoch abi.ChainEpoch // -1 if deal never slashed | ||
| SectorNumber abi.SectorNumber // 0 if not activated or not supported (pre-nv22) | ||
| } | ||
|
|
||
| func MakeDealState(mds market.DealState) MarketDealState { |
There was a problem hiding this comment.
this is missing SectorNumber in the constructor
|
I accidentally did the same PR at #11998, but I have the minor fix I mentioned above; perhaps someone could review that PR and we can just land it. Or fix this one and land it, either way is fine. |
|
merged #11998 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Prompted by the fact that this will be really useful for me in RIBS, and very likely for others - it is now much, much easier to match on-chain deals with sectors.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps