-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): archive old changelog entries #12757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this @rvagg , and I'm wondering about taking it fuurther for 1.30.0+ going forward.
What if we create one changelog file per minor release?
I'd like to get out of the business of duplicating the content between changelog files and the github release. I'm proposing the github release page just have an authoritative link to the changelog for the release. (Why? Prevent duplication, but also because there's not PR process around edits to the release page.)
I think this process is simplified if we have easy-to-construct and deterministic URLs to a given release's changelog. Something like:
https://github.com/filecoin-project/lotus/tree/release/vX.Y/Z/documentation/changelog/CHANGELOG_X.Y.x.md
or
https://github.com/filecoin-project/lotus/tree/release/miner/vX.Y/Z/documentation/changelog/CHANGELOG_X.Y.x.md
https://github.com/filecoin-project/lotus/blob/master/CHANGELOG.md can still house the unreleased work and the links to all the changelog files. Before creating the release branch though we'd create the new documentation/changelog/CHANGELOG_X.Y.x.md
file and clear the "unreleased work" section in master/CHANGELOG.md
so there should be no conflicts later when when we merge back from the release branch to master.
I'm happy to talk more verbally or write this out better.
Even if we go with some variant of what I'm suggesting, I don't think it blocks shipping what you've done.
Thanks again.
@rvagg spoke on this more 2024-12-05. Some brief notes:
|
CHANGELOG.md is finally too big for GitHub's angry unicorn to render properly.
I'm going pretty hard on this one, archiving everything prior to 1.30.0; grouping them by every 10 versions in semver-minor, and providing a TOC and an index for old versions. Open to suggestions for alternative approaches.
I also wouldn't mind reconsidering out approach to the "unreleased" section because it's the main source of git conflicts when merging, backporting or cherry-picking. I'm thinking that a proposed changelog entry might be better off going in the GitHub PR comment thread somewhere and we can have tooling pick it out. Or; maybe we come up with a convention for how to put it in commit metadata. But maybe we can look at that as a separate item.
Direct links to previews of the edited files: