-
Notifications
You must be signed in to change notification settings - Fork 141
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Update filecoin-proofs-api to v18 Update filecoin-proofs-api to v18 * Bump to 2.8.0 Bump to 2.8.0 * Update cargo.lock and changelog Update cargo.lock and changelog * fix: remove the pairing feature from fvm_shared (#2009) The `pairing` feature from the `fvm_shared` crate isn't used. It causes problems, as it forces the `subtle` dependency to v2.4.1, although the rest is happy to have v2.5.0. Here is a detailed dependency graph and issue outline: `fvm_shared` depends on `bls-signatures`. In `bls-signatures` we depend on an old version (v0.11) of `hkdf`. That version depends on `hmac` v0.11, which depends on `crypto-mac` v0.11. `crypto-mac` v0.11.0 depends on `subtle` v2. That is fine, it would automatically select v2.5.0. The problem is that `crypto-mac` v0.11.1 pins `subtle` to exactly v2.4, therefore v2.5.0 won't be selected. The obvious thing is to upgrade in`bls-signatures` the version of `hkdf` to the latest v0.12. That would make it possible to use `subtle` v2.5.0. The problem is that such an upgrade is not easily possible. `hkdf` v0.12 depends on a newer version v0.10 of the `sha2` crate. Updating that breaks the `bls12_381` crate. The reason is the current version v0.8.0 of `bls12_381` depends on an old version v0.9 of the `digest` crate. The obvious thing is to upgrade in `bls12_381` the version of `digest` to v0.10. That would make it possible to get `hkdf` v0.12 built. But such an upgrade is and open issue at zkcrypto/bls12_381#102, which mentions that it's blocked on zkcrypto/bls12_381#90. That pull request is about updating do the hash-to-curve draft v16, currently it's using v12. We use that code path in `bls-signatures`, else we wouldn't enable the `experimental` feature of `bls12_381`. So it's even not clear if we'd want such a change to v16. * Update cargo.lock and Changelog.md Update cargo.locl and Changelog.md * Update fvm_shared, cargo.lock and changelog Update fvm_shared, cargo.lock and changelog --------- Co-authored-by: Volker Mische <[email protected]>
- Loading branch information
Showing
6 changed files
with
40 additions
and
82 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
[package] | ||
name = "fvm_shared" | ||
description = "Filecoin Virtual Machine shared types and functions" | ||
version = "2.6.0" | ||
version = "2.7.0" | ||
edition = "2021" | ||
license = "MIT OR Apache-2.0" | ||
authors = ["ChainSafe Systems <[email protected]>", "Protocol Labs", "Filecoin Core Devs"] | ||
|
@@ -33,7 +33,7 @@ arbitrary = { version = "1.1", optional = true, features = ["derive"]} | |
## non-wasm dependencies; these dependencies and the respective code is | ||
## only activated through non-default features, which the Kernel enables, but | ||
## not the actors. | ||
filecoin-proofs-api = { version = "16", default-features = false, optional = true } | ||
filecoin-proofs-api = { version = "18", default-features = false, optional = true } | ||
libsecp256k1 = { version = "0.7", optional = true } | ||
bls-signatures = { version = "0.15", default-features = false, optional = true } | ||
byteorder = "1.4.3" | ||
|
@@ -50,6 +50,5 @@ crypto = ["libsecp256k1", "blst", "proofs"] | |
proofs = ["filecoin-proofs-api"] | ||
secp256k1 = ["libsecp256k1"] | ||
blst = ["bls-signatures/blst"] | ||
pairing = ["bls-signatures/pairing"] | ||
testing = [] | ||
arb = ["arbitrary"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters