Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway conformance #449

Merged
merged 33 commits into from
Jun 27, 2023
Merged

Gateway conformance #449

merged 33 commits into from
Jun 27, 2023

Conversation

guanzo
Copy link
Collaborator

@guanzo guanzo commented Jun 27, 2023

Fixes #447. Runs the L1 through the gateway conformance tests for specs: trustless-block-gateway, trustless-car-gateway

  • Configures lassie to fetch test cids from a localhost kubo node.
  • Adds njs module to set the content-disposition header
  • All tests pass except for range requests.

A bunch of other commits got pulled in somehow >.<, sorry

@guanzo guanzo force-pushed the gateway-conformance branch from 8e74582 to f8181a5 Compare June 27, 2023 04:12
@guanzo guanzo requested review from DiegoRBaquero and joaosa June 27, 2023 04:28
Copy link
Contributor

@joaosa joaosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just a few very minor comments

@DiegoRBaquero
Copy link
Collaborator

Can you please rebase/cherry pick after clean main to clean up other commits ?

@guanzo guanzo force-pushed the gateway-conformance branch from c8e8eab to fd021f5 Compare June 27, 2023 19:21
@guanzo
Copy link
Collaborator Author

guanzo commented Jun 27, 2023

fixed commits

@guanzo guanzo merged commit 7ab54c9 into main Jun 27, 2023
@guanzo guanzo deleted the gateway-conformance branch June 27, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run conformance test in CI
3 participants