-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway conformance #449
Merged
Merged
Gateway conformance #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanzo
force-pushed
the
gateway-conformance
branch
from
June 27, 2023 04:12
8e74582
to
f8181a5
Compare
joaosa
reviewed
Jun 27, 2023
joaosa
reviewed
Jun 27, 2023
joaosa
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just a few very minor comments
Can you please rebase/cherry pick after clean main to clean up other commits ? |
guanzo
force-pushed
the
gateway-conformance
branch
from
June 27, 2023 19:21
c8e8eab
to
fd021f5
Compare
Signed-off-by: Eric Guan <[email protected]>
fixed commits |
DiegoRBaquero
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #447. Runs the L1 through the gateway conformance tests for specs:
trustless-block-gateway
,trustless-car-gateway
content-disposition
headerA bunch of other commits got pulled in somehow >.<, sorry