Skip to content

Commit

Permalink
Merge pull request #438 from mtsokol/similar-fill-value-support
Browse files Browse the repository at this point in the history 
API: Add `fill_value` and `fill_value_type` config argument to `Base.similar`
  • Loading branch information
@willow-ahrens
willow-ahrens authored Feb 29, 2024
2 parents 598f225 + 9cd7f7d commit 4006218
Show file tree
Hide file tree
Showing 25 changed files with 105 additions and 44 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Finch"
uuid = "9177782c-1635-4eb9-9bfb-d9dfa25e6bce"
authors = ["Willow Ahrens"]
version = "0.6.13"
version = "0.6.14"

[deps]
AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
Expand Down
8 changes: 6 additions & 2 deletions src/tensors/fibers.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,11 @@ end
Base.summary(fbr::Tensor) = "$(join(size(fbr), "×")) Tensor($(summary(fbr.lvl)))"
Base.summary(fbr::SubFiber) = "$(join(size(fbr), "×")) SubFiber($(summary(fbr.lvl)))"

Base.similar(fbr::AbstractFiber) = Tensor(similar_level(fbr.lvl))
Base.similar(fbr::AbstractFiber, dims::Tuple) = Tensor(similar_level(fbr.lvl, dims...))
Base.similar(fbr::AbstractFiber) = similar(fbr, default(fbr), eltype(fbr), size(fbr))
Base.similar(fbr::AbstractFiber, eltype::Type) = similar(fbr, convert(eltype, default(fbr)), eltype, size(fbr))
Base.similar(fbr::AbstractFiber, fill_value, eltype::Type) = similar(fbr, fill_value, eltype, size(fbr))
Base.similar(fbr::AbstractFiber, dims::Tuple) = similar(fbr, default(fbr), eltype(fbr), dims)
Base.similar(fbr::AbstractFiber, eltype::Type, dims::Tuple) = similar(fbr, convert(eltype, default(fbr)), eltype, dims)
Base.similar(fbr::AbstractFiber, fill_value, eltype::Type, dims::Tuple) = Tensor(similar_level(fbr.lvl, fill_value, eltype, dims...))

moveto(tns::Tensor, device) = Tensor(moveto(tns.lvl, device))
3 changes: 2 additions & 1 deletion src/tensors/levels/atomiclevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ AtomicLevel(lvl::Lvl) where {Lvl} = AtomicLevel{Vector{Base.Threads.SpinLock}, L
# AtomicLevel{AVal, Lvl}(atomics::AVal, lvl::Lvl) where {Lvl, AVal} = AtomicLevel{AVal, Lvl}(lvl, atomics)
Base.summary(::AtomicLevel{AVal, Lvl}) where {Lvl, AVal} = "AtomicLevel($(AVal), $(Lvl))"

similar_level(lvl::Atomic{AVal, Lvl}) where {Lvl, AVal} = AtomicLevel{AVal, Lvl}(similar_level(lvl.lvl))
similar_level(lvl::Atomic{AVal, Lvl}, fill_value, eltype::Type, dims...) where {Lvl, AVal} =
AtomicLevel(similar_level(lvl.lvl, fill_value, eltype, dims...))

postype(::Type{<:AtomicLevel{AVal, Lvl}}) where {Lvl, AVal} = postype(Lvl)

Expand Down
5 changes: 3 additions & 2 deletions src/tensors/levels/denselevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ DenseLevel{Ti}(lvl::Lvl, shape) where {Ti, Lvl} = DenseLevel{Ti, Lvl}(lvl, shape
const Dense = DenseLevel

Base.summary(lvl::Dense) = "Dense($(summary(lvl.lvl)))"
similar_level(lvl::DenseLevel) = Dense(similar_level(lvl.lvl))
similar_level(lvl::DenseLevel, dims...) = Dense(similar_level(lvl.lvl, dims[1:end-1]...), dims[end])

similar_level(lvl::DenseLevel, fill_value, eltype::Type, dims...) =
Dense(similar_level(lvl.lvl, fill_value, eltype, dims[1:end-1]...), dims[end])

function postype(::Type{DenseLevel{Ti, Lvl}}) where {Ti, Lvl}
return postype(Lvl)
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/denserlelevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ DenseRLELevel{Ti}(lvl::Lvl, shape, ptr::Ptr, right::Right, buf::Lvl) where {Ti,
DenseRLELevel{Ti, Ptr, Right, Lvl}(lvl, Ti(shape), ptr, right, buf)

Base.summary(lvl::DenseRLELevel) = "DenseRLE($(summary(lvl.lvl)))"
similar_level(lvl::DenseRLELevel) = DenseRLE(similar_level(lvl.lvl))
similar_level(lvl::DenseRLELevel, dim, tail...) = DenseRLE(similar_level(lvl.lvl, tail...), dim)
similar_level(lvl::DenseRLELevel, fill_value, eltype::Type, dim, tail...) =
DenseRLE(similar_level(lvl.lvl, fill_value, eltype, tail...), dim)

function postype(::Type{DenseRLELevel{Ti, Ptr, Right, Lvl}}) where {Ti, Ptr, Right, Lvl}
return postype(Lvl)
Expand Down
5 changes: 3 additions & 2 deletions src/tensors/levels/elementlevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ A subfiber of an element level is a scalar of type `Tv`, initialized to `D`. `D`
may optionally be given as the first argument.
The data is stored in a vector
of type `Val` with `eltype(Val) = Tv`. The type `Ti` is the index type used to
of type `Val` with `eltype(Val) = Tv`. The type `Tp` is the index type used to
access Val.
```jldoctest
Expand Down Expand Up @@ -34,7 +34,8 @@ ElementLevel{D, Tv, Tp}(val::Val) where {D, Tv, Tp, Val} = ElementLevel{D, Tv, T

Base.summary(::Element{D}) where {D} = "Element($(D))"

similar_level(::ElementLevel{D, Tv, Tp}) where {D, Tv, Tp} = ElementLevel{D, Tv, Tp}()
similar_level(::ElementLevel{D, Tv, Tp}, fill_value, eltype::Type, ::Vararg) where {D, Tv, Tp} =
ElementLevel{fill_value, eltype, Tp}()

postype(::Type{<:ElementLevel{D, Tv, Tp}}) where {D, Tv, Tp} = Tp

Expand Down
2 changes: 1 addition & 1 deletion src/tensors/levels/patternlevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const Pattern = PatternLevel
PatternLevel() = PatternLevel{Int}()

Base.summary(::Pattern) = "Pattern()"
similar_level(::PatternLevel) = PatternLevel()
similar_level(::PatternLevel, ::Any, ::Type, ::Vararg) = PatternLevel()

countstored_level(lvl::PatternLevel, pos) = pos

Expand Down
3 changes: 1 addition & 2 deletions src/tensors/levels/repeatrlelevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ RepeatRLELevel{D, Ti, Tp, Tv}(shape, ptr::Ptr, idx::Idx, val::Val) where {D, Ti,
RepeatRLELevel{D, Ti, Tp, Tv, Ptr, Idx, Val}(shape, ptr, idx, val)

Base.summary(::RepeatRLE{D}) where {D} = "RepeatRLE($(D))"
similar_level(::RepeatRLELevel{D}) where {D} = RepeatRLE{D}()
similar_level(::RepeatRLELevel{D}, dim, tail...) where {D} = RepeatRLE{D}(dim)
similar_level(::RepeatRLELevel{D}, ::Any, ::Type, dim, tail...) where {D} = RepeatRLE{D}(dim)
data_rep_level(::Type{<:RepeatRLELevel{D, Ti, Tp, Tv, Ptr, Idx, Val}}) where {D, Ti, Tp, Tv, Ptr, Idx, Val} = RepeatData(D, Tv)

function postype(::Type{RepeatRLELevel{D, Ti, Tp, Tv, Ptr, Idx, Val}}) where {D, Ti, Tp, Tv, Ptr, Idx, Val}
Expand Down
10 changes: 8 additions & 2 deletions src/tensors/levels/separatelevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ SeparateLevel(lvl::Lvl) where {Lvl} = SeparateLevel(lvl, [lvl])
SeparateLevel{Lvl, Val}(lvl::Lvl) where {Lvl, Val} = SeparateLevel{Lvl, Val}(lvl, [lvl])
Base.summary(::Separate{Lvl, Val}) where {Lvl, Val} = "Separate($(Lvl))"

similar_level(lvl::Separate{Lvl, Val}) where {Lvl, Val} = SeparateLevel{Lvl, Val}(similar_level(lvl.lvl))
similar_level(lvl::Separate{Lvl, Val}, fill_value, eltype::Type, dims...) where {Lvl, Val} =
SeparateLevel(similar_level(lvl.lvl, fill_value, eltype, dims...))

postype(::Type{<:Separate{Lvl, Val}}) where {Lvl, Val} = postype(Lvl)

Expand Down Expand Up @@ -128,7 +129,12 @@ function assemble_level!(lvl::VirtualSeparateLevel, ctx, pos_start, pos_stop)
push!(ctx.code.preamble, quote
Finch.resize_if_smaller!($(lvl.ex).val, $(ctx(pos_stop)))
for $pos in $(ctx(pos_start)):$(ctx(pos_stop))
$sym = similar_level($(lvl.ex).lvl)
$sym = similar_level(
$(lvl.ex).lvl,
level_default(typeof($(lvl.ex).lvl)),
level_eltype(typeof($(lvl.ex).lvl)),
$(map(ctx, map(getstop, virtual_level_size(lvl, ctx)))...)
)
$(contain(ctx) do ctx_2
lvl_2 = virtualize(sym, lvl.Lvl, ctx_2.code, sym)
lvl_2 = declare_level!(lvl_2, ctx_2, literal(0), literal(virtual_level_default(lvl_2)))
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/singlelistlevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ SingleListLevel{Ti}(lvl::Lvl, shape, ptr::Ptr, idx::Idx) where {Ti, Lvl, Ptr, Id
SingleListLevel{Ti, Ptr, Idx, Lvl}(lvl, shape, ptr, idx)

Base.summary(lvl::SingleListLevel) = "SingleList($(summary(lvl.lvl)))"
similar_level(lvl::SingleListLevel) = SingleList(similar_level(lvl.lvl))
similar_level(lvl::SingleListLevel, dim, tail...) = SingleList(similar_level(lvl.lvl, tail...), dim)
similar_level(lvl::SingleListLevel, fill_value, eltype::Type, dim, tail...) =
SingleList(similar_level(lvl.lvl, fill_value, eltype, tail...), dim)

function postype(::Type{SingleListLevel{Ti, Ptr, Idx, Lvl}}) where {Ti, Ptr, Idx, Lvl}
return postype(Lvl)
Expand Down
6 changes: 3 additions & 3 deletions src/tensors/levels/singlerlelevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ SingleRLELevel{Ti}(lvl, shape) where {Ti} = SingleRLELevel{Ti}(lvl, shape, posty

SingleRLELevel{Ti}(lvl::Lvl, shape, ptr::Ptr, left::Left, right::Right) where {Ti, Lvl, Ptr, Left, Right} =
SingleRLELevel{Ti, Ptr, Left, Right, Lvl}(lvl, shape, ptr, left, right)

Base.summary(lvl::SingleRLELevel) = "SingleRLE($(summary(lvl.lvl)))"
similar_level(lvl::SingleRLELevel) = SingleRLE(similar_level(lvl.lvl))
similar_level(lvl::SingleRLELevel, dim, tail...) = SingleRLE(similar_level(lvl.lvl, tail...), dim)
similar_level(lvl::SingleRLELevel, fill_value, eltype::Type, dim, tail...) =
SingleRLE(similar_level(lvl.lvl, fill_value, eltype, tail...), dim)

function memtype(::Type{SingleRLELevel{Ti, Ptr, Left, Right, Lvl}}) where {Ti, Ptr, Left, Right, Lvl}
return Ti
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/sparsebandlevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ function moveto(lvl::SparseBandLevel{Ti}, device) where {Ti}
end

Base.summary(lvl::SparseBandLevel) = "SparseBand($(summary(lvl.lvl)))"
similar_level(lvl::SparseBandLevel) = SparseBand(similar_level(lvl.lvl))
similar_level(lvl::SparseBandLevel, dim, tail...) = SparseBand(similar_level(lvl.lvl, tail...), dim)
similar_level(lvl::SparseBandLevel, fill_value, eltype::Type, dim, tail...) =
SparseBand(similar_level(lvl.lvl, fill_value, eltype, tail...), dim)

pattern!(lvl::SparseBandLevel{Ti}) where {Ti} =
SparseBandLevel{Ti}(pattern!(lvl.lvl), lvl.shape, lvl.ptr, lvl.idx, lvl.ofs)
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/sparsebytemaplevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ SparseByteMapLevel{Ti}(lvl::Lvl, shape, ptr::Ptr, tbl::Tbl, srt::Srt) where {Ti,
SparseByteMapLevel{Ti, Ptr, Tbl, Srt, Lvl}(lvl, shape, ptr, tbl, srt)

Base.summary(lvl::SparseByteMapLevel) = "SparseByteMap($(summary(lvl.lvl)))"
similar_level(lvl::SparseByteMapLevel) = SparseByteMap(similar_level(lvl.lvl))
similar_level(lvl::SparseByteMapLevel, dims...) = SparseByteMap(similar_level(lvl.lvl, dims[1:end-1]...), dims[end])
similar_level(lvl::SparseByteMapLevel, fill_value, eltype::Type, dims...) =
SparseByteMap(similar_level(lvl.lvl, fill_value, eltype, dims[1:end-1]...), dims[end])

function postype(::Type{SparseByteMapLevel{Ti, Ptr, Tbl, Srt, Lvl}}) where {Ti, Ptr, Tbl, Srt, Lvl}
return postype(Lvl)
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/sparsecoolevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ SparseCOOLevel{N, TI}(lvl::Lvl, shape, ptr::Ptr, tbl::Tbl) where {N, TI, Lvl, Pt
SparseCOOLevel{N, TI, Ptr, Tbl, Lvl}(lvl, TI(shape), ptr, tbl)

Base.summary(lvl::SparseCOOLevel{N}) where {N} = "SparseCOO{$N}($(summary(lvl.lvl)))"
similar_level(lvl::SparseCOOLevel{N}) where {N} = SparseCOOLevel{N}(similar_level(lvl.lvl))
similar_level(lvl::SparseCOOLevel{N}, tail...) where {N} = SparseCOOLevel{N}(similar_level(lvl.lvl, tail[1:end-N]...), (tail[end-N+1:end]...,))
similar_level(lvl::SparseCOOLevel{N}, fill_value, eltype::Type, tail...) where {N} =
SparseCOOLevel{N}(similar_level(lvl.lvl, fill_value, eltype, tail[1:end-N]...), (tail[end-N+1:end]...,))

function postype(::Type{SparseCOOLevel{N, TI, Ptr, Tbl, Lvl}}) where {N, TI, Ptr, Tbl, Lvl}
return postype(Lvl)
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/sparsehashlevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ SparseHashLevel{N, TI}(lvl::Lvl, shape, ptr::Ptr, tbl::Tbl, srt::Srt) where {N,
SparseHashLevel{N, TI, Ptr, Tbl, Srt, Lvl}(lvl, shape, ptr, tbl, srt)

Base.summary(lvl::SparseHashLevel{N}) where {N} = "SparseHash{$N}($(summary(lvl.lvl)))"
similar_level(lvl::SparseHashLevel{N}) where {N} = SparseHashLevel{N}(similar_level(lvl.lvl))
similar_level(lvl::SparseHashLevel{N}, tail...) where {N} = SparseHashLevel{N}(similar_level(lvl.lvl, tail[1:end-N]...), (tail[end-N+1:end]...,))
similar_level(lvl::SparseHashLevel{N}, fill_value, eltype::Type, tail...) where {N} =
SparseHashLevel{N}(similar_level(lvl.lvl, fill_value, eltype, tail[1:end-N]...), (tail[end-N+1:end]...,))

function postype(::Type{SparseHashLevel{N, TI, Ptr, Tbl, Srt, Lvl}}) where {N, TI, Ptr, Tbl, Srt, Lvl}
return postype(Lvl)
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/sparselevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ SparseLevel{Ti}(lvl::Lvl, shape, tbl::Tbl) where {Ti, Lvl, Tbl} =
SparseLevel{Ti, Tbl, Lvl}(lvl, shape, tbl)

Base.summary(lvl::SparseLevel) = "Sparse($(summary(lvl.lvl)))"
similar_level(lvl::SparseLevel) = Sparse(similar_level(lvl.lvl))
similar_level(lvl::SparseLevel, dim, tail...) = Sparse(similar_level(lvl.lvl, tail...), dim)
similar_level(lvl::SparseLevel, fill_value, eltype::Type, dim, tail...) =
Sparse(similar_level(lvl.lvl, fill_value, eltype, tail...), dim)

function postype(::Type{SparseLevel{Ti, Tbl, Lvl}}) where {Ti, Tbl, Lvl}
return postype(Lvl)
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/sparselistlevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ SparseListLevel{Ti}(lvl::Lvl, shape, ptr::Ptr, idx::Idx) where {Ti, Lvl, Ptr, Id
SparseListLevel{Ti, Ptr, Idx, Lvl}(lvl, shape, ptr, idx)

Base.summary(lvl::SparseListLevel) = "SparseList($(summary(lvl.lvl)))"
similar_level(lvl::SparseListLevel) = SparseList(similar_level(lvl.lvl))
similar_level(lvl::SparseListLevel, dim, tail...) = SparseList(similar_level(lvl.lvl, tail...), dim)
similar_level(lvl::SparseListLevel, fill_value, eltype::Type, dim, tail...) =
SparseList(similar_level(lvl.lvl, fill_value, eltype, tail...), dim)

function postype(::Type{SparseListLevel{Ti, Ptr, Idx, Lvl}}) where {Ti, Ptr, Idx, Lvl}
return postype(Lvl)
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/sparserlelevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ SparseRLELevel{Ti}(lvl::Lvl, shape, ptr::Ptr, left::Left, right::Right, buf::Lvl
SparseRLELevel{Ti, Ptr, Left, Right, Lvl}(lvl, Ti(shape), ptr, left, right, buf)

Base.summary(lvl::SparseRLELevel) = "SparseRLE($(summary(lvl.lvl)))"
similar_level(lvl::SparseRLELevel) = SparseRLE(similar_level(lvl.lvl))
similar_level(lvl::SparseRLELevel, dim, tail...) = SparseRLE(similar_level(lvl.lvl, tail...), dim)
similar_level(lvl::SparseRLELevel, fill_value, eltype::Type, dim, tail...) =
SparseRLE(similar_level(lvl.lvl, fill_value, eltype, tail...), dim)

function postype(::Type{SparseRLELevel{Ti, Ptr, Left, Right, Lvl}}) where {Ti, Ptr, Left, Right, Lvl}
return postype(Lvl)
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/sparsetrianglelevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ SparseTriangleLevel{N, Ti, Lvl}(lvl) where {N, Ti, Lvl} = SparseTriangleLevel{N,
const SparseTriangle = SparseTriangleLevel

Base.summary(lvl::SparseTriangle{N}) where {N} = "SparseTriangle{$N}($(summary(lvl.lvl)))"
similar_level(lvl::SparseTriangle{N}) where {N} = SparseTriangle(similar_level(lvl.lvl))
similar_level(lvl::SparseTriangle{N}, dims...) where {N} = SparseTriangle(similar_level(lvl.lvl, dims[1:end-1]...), dims[end])
similar_level(lvl::SparseTriangle{N}, fill_value, eltype::Type, dims...) where {N} =
SparseTriangle(similar_level(lvl.lvl, fill_value, eltype, dims[1:end-1]...), dims[end])

function postype(::Type{SparseTriangleLevel{N, Ti, Lvl}}) where {N, Ti, Lvl}
return postype(Lvl)
Expand Down
4 changes: 2 additions & 2 deletions src/tensors/levels/sparsevbllevels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ function moveto(lvl::SparseVBLLevel{Ti}, device) where {Ti}
end

Base.summary(lvl::SparseVBLLevel) = "SparseVBL($(summary(lvl.lvl)))"
similar_level(lvl::SparseVBLLevel) = SparseVBL(similar_level(lvl.lvl))
similar_level(lvl::SparseVBLLevel, dim, tail...) = SparseVBL(similar_level(lvl.lvl, tail...), dim)
similar_level(lvl::SparseVBLLevel, fill_value, eltype::Type, dim, tail...) =
SparseVBL(similar_level(lvl.lvl, fill_value, eltype, tail...), dim)

pattern!(lvl::SparseVBLLevel{Ti}) where {Ti} =
SparseVBLLevel{Ti}(pattern!(lvl.lvl), lvl.shape, lvl.ptr, lvl.idx, lvl.ofs)
Expand Down
2 changes: 1 addition & 1 deletion test/reference32/conversions/convert_to_Dense{Separate}{Element{false}}.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ begin
result = nothing
Finch.resize_if_smaller!(tmp_lvl.val, 1)
for pos = 1:1
pointer_to_lvl = similar_level(tmp_lvl.lvl)
pointer_to_lvl = similar_level(tmp_lvl.lvl, level_default(typeof(tmp_lvl.lvl)), level_eltype(typeof(tmp_lvl.lvl)), ref_lvl.shape)
pointer_to_lvl_3 = pointer_to_lvl.lvl
pointer_to_lvl_2_val = pointer_to_lvl.lvl.val
Finch.resize_if_smaller!(pointer_to_lvl_2_val, ref_lvl.shape)
Expand Down
4 changes: 2 additions & 2 deletions test/reference32/conversions/convert_to_SparseList{Separate}{Element{false}}.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ begin
Finch.resize_if_smaller!(tmp_lvl_idx, tmp_lvl_qos_stop)
Finch.resize_if_smaller!(tmp_lvl_2.val, tmp_lvl_qos_stop)
for pos = tmp_lvl_qos:tmp_lvl_qos_stop
pointer_to_lvl = similar_level(tmp_lvl_2.lvl)
pointer_to_lvl = similar_level(tmp_lvl_2.lvl, level_default(typeof(tmp_lvl_2.lvl)), level_eltype(typeof(tmp_lvl_2.lvl)))
pointer_to_lvl_val = pointer_to_lvl.val
Finch.resize_if_smaller!(pointer_to_lvl_val, 1)
Finch.fill_range!(pointer_to_lvl_val, false, 1, 1)
Expand All @@ -62,7 +62,7 @@ begin
Finch.resize_if_smaller!(tmp_lvl_idx, tmp_lvl_qos_stop)
Finch.resize_if_smaller!(tmp_lvl_2.val, tmp_lvl_qos_stop)
for pos_2 = tmp_lvl_qos:tmp_lvl_qos_stop
pointer_to_lvl_5 = similar_level(tmp_lvl_2.lvl)
pointer_to_lvl_5 = similar_level(tmp_lvl_2.lvl, level_default(typeof(tmp_lvl_2.lvl)), level_eltype(typeof(tmp_lvl_2.lvl)))
pointer_to_lvl_5_val = pointer_to_lvl_5.val
Finch.resize_if_smaller!(pointer_to_lvl_5_val, 1)
Finch.fill_range!(pointer_to_lvl_5_val, false, 1, 1)
Expand Down
2 changes: 1 addition & 1 deletion test/reference64/conversions/convert_to_Dense{Separate}{Element{false}}.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ begin
result = nothing
Finch.resize_if_smaller!(tmp_lvl.val, 1)
for pos = 1:1
pointer_to_lvl = similar_level(tmp_lvl.lvl)
pointer_to_lvl = similar_level(tmp_lvl.lvl, level_default(typeof(tmp_lvl.lvl)), level_eltype(typeof(tmp_lvl.lvl)), ref_lvl.shape)
pointer_to_lvl_3 = pointer_to_lvl.lvl
pointer_to_lvl_2_val = pointer_to_lvl.lvl.val
Finch.resize_if_smaller!(pointer_to_lvl_2_val, ref_lvl.shape)
Expand Down
4 changes: 2 additions & 2 deletions test/reference64/conversions/convert_to_SparseList{Separate}{Element{false}}.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ begin
Finch.resize_if_smaller!(tmp_lvl_idx, tmp_lvl_qos_stop)
Finch.resize_if_smaller!(tmp_lvl_2.val, tmp_lvl_qos_stop)
for pos = tmp_lvl_qos:tmp_lvl_qos_stop
pointer_to_lvl = similar_level(tmp_lvl_2.lvl)
pointer_to_lvl = similar_level(tmp_lvl_2.lvl, level_default(typeof(tmp_lvl_2.lvl)), level_eltype(typeof(tmp_lvl_2.lvl)))
pointer_to_lvl_val = pointer_to_lvl.val
Finch.resize_if_smaller!(pointer_to_lvl_val, 1)
Finch.fill_range!(pointer_to_lvl_val, false, 1, 1)
Expand All @@ -62,7 +62,7 @@ begin
Finch.resize_if_smaller!(tmp_lvl_idx, tmp_lvl_qos_stop)
Finch.resize_if_smaller!(tmp_lvl_2.val, tmp_lvl_qos_stop)
for pos_2 = tmp_lvl_qos:tmp_lvl_qos_stop
pointer_to_lvl_5 = similar_level(tmp_lvl_2.lvl)
pointer_to_lvl_5 = similar_level(tmp_lvl_2.lvl, level_default(typeof(tmp_lvl_2.lvl)), level_eltype(typeof(tmp_lvl_2.lvl)))
pointer_to_lvl_5_val = pointer_to_lvl_5.val
Finch.resize_if_smaller!(pointer_to_lvl_5_val, 1)
Finch.fill_range!(pointer_to_lvl_5_val, false, 1, 1)
Expand Down
Loading

2 comments on commit 4006218

@willow-ahrens
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/102006

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.6.14 -m "<description of version>" 40062184c4158f47d72265dc979cd843129aee7b
git push origin v0.6.14

Please sign in to comment.