Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative resource paths in PDX root #103

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

STREGA
Copy link
Contributor

@STREGA STREGA commented Nov 21, 2024

Adds resource subdirectory preservation so users can organize their subdirectories and take advantage of pdxinfo features to allow marketing resources to be grouped.

Resources are copied with their relative folder structure preserved.
A Resources folder is required in the package module source and only it's contents are copied.
This removes the possibility of copying things like Source Art and documentation to the pdx.

PlaydateKit's Resources/Core/ has been renamed to Resources/PlaydateKit/ which is less likely to cause collisions with users own resource subdirectory names.

The pdxinfo file is always copied to the pdx root no matter what subdirectory it is in.

This PR builds on the ideas in #75 by @YogurtTheHorse

With relative resource paths, this will make loading PlaydateKit resources require the PlaydateKit prefix which is less likely to collide with users own directory names.
Copy link
Owner

@finnvoor finnvoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@finnvoor finnvoor enabled auto-merge (squash) November 21, 2024 12:05
@finnvoor finnvoor merged commit 473a271 into finnvoor:main Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants