Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Igallizugaro website review #3300

Open
wants to merge 467 commits into
base: master
Choose a base branch
from

Conversation

igallizugaro
Copy link

Hi Eteri,
I would like to please create a pull request.

Thank you
Isabella

link to diagram page added
links to gov page, development approach and roadmap added
link to structure diagram added
group roles scope image added
links to governance and wg pages added
cdm org structure link added
splitting out change control guidielines from gov page here
split change control guidelines into own page
removing backwards compatibility section to add into change control guidelines page
added Backward Compatibility
link to change control guidelines page
heading added
image added
link to cdm organisation page added
link to roadmap page added
dshoneisda
dshoneisda previously approved these changes Jan 9, 2025
@LionelSG-REGnosys LionelSG-REGnosys added the Category: Documentation Individual Maintainer May Approve label Jan 20, 2025
Copy link
Contributor

@chrisisla chrisisla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my comments may not be valid as it could be that the documents are not present on the version of the website (e.g. Standardized IM calc, WG lists). Other than that there are just a few typos and duplicated words to sort out please 😃

docs/cdm-overview.md Outdated Show resolved Hide resolved
docs/contributions.md Outdated Show resolved Hide resolved
docs/get-involved.md Outdated Show resolved Hide resolved
docs/home.mdx Show resolved Hide resolved
docs/home.mdx Show resolved Hide resolved
docs/maintenance-and-release.md Outdated Show resolved Hide resolved
docs/maintenance-and-release.md Show resolved Hide resolved
docs/working-groups.md Outdated Show resolved Hide resolved
docs/working-groups.md Show resolved Hide resolved
docs/working-groups.md Show resolved Hide resolved
eacunaISDA
eacunaISDA previously approved these changes Jan 27, 2025
@chrisisla
Copy link
Contributor

There are now 1246 files being updated in this PR, I'm not sure we can approve/merge this as is I'm afraid...

Copy link
Contributor

@chrisisla chrisisla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that sentence in the maintenance-and-release.md file to correct and then we're all done 😄

Copy link
Contributor

@chrisisla chrisisla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Documentation Individual Maintainer May Approve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants