Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/3511 setting meta in nested objects #914

Merged
merged 13 commits into from
Jan 31, 2025

Conversation

davidalk
Copy link
Contributor

@davidalk davidalk commented Jan 30, 2025

This PR implements the ability to set meta where it is nested in objects using the set/add operators as outlined in the first section of #847

@davidalk davidalk marked this pull request as ready for review January 31, 2025 14:24
«oldExpr»
«generateMetaWrapperCreator(seg, prop, outputExpressionType)».«IF op.ROperationType == ROperationType.ADD»add«ELSE»set«ENDIF»«propertySetterName»«IF requiresValueSetter»Value«ENDIF»(«it»)''',
JavaPrimitiveType.VOID
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@davidalk davidalk changed the title Story/3511/with meta phase 4 Story/3511 setting meta in nested objects Jan 31, 2025
@davidalk davidalk merged commit 98d63bd into finos:main Jan 31, 2025
3 checks passed
@davidalk davidalk deleted the story/3511/with-meta-phase-4 branch January 31, 2025 15:23
@hugohills-regnosys
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants