Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gradle wrapper to 6.7.1 #1471

Closed
wants to merge 20 commits into from
Closed

Upgrade gradle wrapper to 6.7.1 #1471

wants to merge 20 commits into from

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Oct 11, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

This PR updates:

  • gradle wrapper to 6.7.1 (was 5.6.4 or earlier)
  • gradle plugin to 4.2.1 (was 3.3.3)
  • compileSdkVersion to 31 (was 28)
  • NDK path to use ANDROID_NDK_HOME environment variable
  • build tools to 30.0.2 (was 28.0.3)

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running integration tests directly in this PR as well as packaging + integration tests.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 11, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 7b4a18a
Last updated: Thu Oct 19 01:45 PDT 2023
View integration test log & download artifacts

Failures Configs
auth [TEST] [FLAKINESS] [Android] [2/3 os: macos ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestAdView
remote_config [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
storage [TEST] [FLAKINESS] [Android] [All 3 os] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 11, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 11, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 11, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 11, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 11, 2023
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Oct 11, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Oct 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 12, 2023
@jonsimantov jonsimantov requested a review from a-maurice October 12, 2023 18:28
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Oct 17, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 18, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 18, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 18, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 19, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 19, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 19, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 19, 2023
@firebase firebase locked and limited conversation to collaborators Jan 12, 2024
@a-maurice a-maurice deleted the upgrade-gradle-wrapper-6.7.1 branch October 1, 2024 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice