Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry to LoadConsentForm for timeouts. #1480

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Add retry to LoadConsentForm for timeouts. #1480

merged 7 commits into from
Oct 20, 2023

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 19, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 19, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 42496c4
Last updated: Fri Oct 20 03:43 PDT 2023
View integration test log & download artifacts

Failures Configs
gma [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 19, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 19, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 19, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 19, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 19, 2023
@jonsimantov jonsimantov marked this pull request as ready for review October 19, 2023 21:49
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Oct 19, 2023
a-maurice
a-maurice approved these changes Oct 19, 2023
View reviewed changes
gma/integration_test/src/integration_test.cc
// If it still timed out after all the retries, let the test pass.
EXPECT_THAT(future.error(),
AnyOf(firebase::gma::ump::kConsentFormSuccess,
firebase::gma::ump::kConsentFormErrorTimeout));

EXPECT_EQ(consent_info_->GetConsentFormStatus(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it times out, is this still going to pass as desired?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@jonsimantov jonsimantov enabled auto-merge (squash) October 19, 2023 21:54
@jonsimantov jonsimantov merged commit 42496c4 into main Oct 20, 2023
24 of 26 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Oct 20, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 20, 2023
@firebase firebase locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice